fix: review opp not show up for reviewers

Author: dedywahyudi

__tests__/shared/components/challenge-listing/Sidebar/__snapshots__/index.jsx.snap

@@ -13,7 +13,6 @@ exports[`Matches shallow shapshot 1`] = `
       disabled={false}
       expanding={false}
       isAuth={false}
-      isReviewer={false}
       past={false}
       selectBucket={[MockFunction]}
     />
@@ -37,7 +36,6 @@ exports[`Matches shallow shapshot 2`] = `
       disabled={false}
       expanding={false}
       isAuth={false}
-      isReviewer={false}
       past={false}
       selectBucket={[MockFunction]}
     />

src/shared/components/challenge-listing/Sidebar/BucketSelector/index.jsx

@@ -7,6 +7,7 @@
 import PT from 'prop-types';
 import React from 'react';
 import { BUCKETS } from 'utils/challenge-listing/buckets';
+import { isReviewerOrAdmin } from 'utils/challenge-listing/helper';
 // import { challenge as challengeUtils } from 'topcoder-react-lib';
 
 import Bucket from './Bucket';
@@ -29,12 +30,12 @@ export default function BucketSelector({
   // extraBucket,
   // filterState,
   isAuth,
-  isReviewer,
   // savedFilters,
   selectBucket,
   // selectSavedFilter,
   // setEditSavedFiltersMode,
   past,
+  auth,
 }) {
   // let filteredChallenges = challenges.filter(Filter.getFilterFunction(filterState));
 
@@ -90,7 +91,7 @@ export default function BucketSelector({
         {getBucket(BUCKETS.OPEN_FOR_REGISTRATION)}
         {/* DISABLED: Until api receive fix community-app#5073 */}
         {/* {getBucket(BUCKETS.ONGOING)} */}
-        {isReviewer ? getBucket(BUCKETS.REVIEW_OPPORTUNITIES) : null}
+        {isReviewerOrAdmin(auth) ? getBucket(BUCKETS.REVIEW_OPPORTUNITIES) : null}
         {/* {getBucket(BUCKETS.PAST)} */}
         {/* NOTE: We do not show upcoming challenges for now, for various reasons,
           * more political than technical ;)
@@ -141,12 +142,16 @@ BucketSelector.defaultProps = {
   disabled: false,
   // extraBucket: null,
   isAuth: false,
-  isReviewer: false,
   expanding: false,
   past: false,
 };
 
 BucketSelector.propTypes = {
+  auth: PT.shape({
+    profile: PT.shape(),
+    tokenV3: PT.string,
+    user: PT.shape(),
+  }).isRequired,
   activeBucket: PT.string.isRequired,
   expanding: PT.bool,
   // activeSavedFilter: PT.number.isRequired,
@@ -158,7 +163,6 @@ BucketSelector.propTypes = {
   // extraBucket: PT.string,
   // filterState: PT.shape().isRequired,
   isAuth: PT.bool,
-  isReviewer: PT.bool,
   // savedFilters: PT.arrayOf(PT.shape()).isRequired,
   selectBucket: PT.func.isRequired,
   // selectSavedFilter: PT.func.isRequired,

src/shared/components/challenge-listing/Sidebar/index.jsx

@@ -17,8 +17,7 @@
 
 import React from 'react';
 import PT from 'prop-types';
-import { isReviewerOrAdmin } from 'utils/challenge-listing/helper';
-// import _ from 'lodash';
+// import { isReviewerOrAdmin } from 'utils/challenge-listing/helper';
 import { isPastBucket } from 'utils/challenge-listing/buckets';
 import ChallengeSearchBar from 'containers/challenge-listing/ChallengeSearchBar';
 import BucketSelector from './BucketSelector';
@@ -115,7 +114,7 @@ export default function SideBarFilters({
           // extraBucket={extraBucket}
           // filterState={filterState}
           isAuth={isAuth}
-          isReviewer={isReviewerOrAdmin(auth)}
+          auth={auth}
           // savedFilters={savedFilters}
           selectBucket={selectBucket}
           // selectSavedFilter={selectSavedFilter}

src/shared/containers/challenge-listing/Sidebar.jsx

@@ -189,6 +189,7 @@ function mapStateToProps(state) {
     // hideTcLinksInFooter: ownProps.hideTcLinksInFooter,
     filterState: state.challengeListing.filter,
     isAuth: Boolean(state.auth.user),
+    auth: state.auth,
     // communityFilters: state.tcCommunities.list.data,
     // selectedCommunityId: state.challengeListing.selectedCommunityId,
     // tokenV2: state.auth.tokenV2,

src/shared/reducers/challenge-listing/index.js

@@ -509,7 +509,7 @@ function onGetReviewOpportunitiesDone(state, { payload, error }) {
     allReviewOpportunitiesLoaded: loaded.length === 0,
     meta: {
       ...state.meta,
-      openReviewCount: loaded.length,
+      openReviewCount: reviewOpportunities.length,
     },
   };
 }

src/shared/utils/challenge-listing/helper.js

@@ -77,5 +77,5 @@ export const isReviewerOrAdmin = (auth) => {
     return false;
   }
 
-  return _.intersection(roles, ['administrator', 'Reviewer']).length;
+  return _.intersection(roles, ['administrator', 'Reviewer', 'Gamification Admin', 'Connect Admin', 'admin']).length;
 };