Skip to content

fix(PM-2456): Update challenge skipped shouldOpenOpportunity property in reviewers #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 22, 2025
Merged

fix(PM-2456): Update challenge skipped shouldOpenOpportunity property in reviewers #23

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9d98622
fix: default shouldOpenOpportunity to false
hentrymartin Oct 20, 2025
2f3c971
fix: default shouldOpenOpportunity to false
hentrymartin Oct 20, 2025
5e9ce7d
Merge branch 'develop' into pm-2456
hentrymartin Oct 20, 2025
8ab3959
debug logs
hentrymartin Oct 22, 2025
d15d6aa
fix: removed debug logs
hentrymartin Oct 22, 2025
a1145bf
Merge branch 'develop' into pm-2456
hentrymartin Oct 22, 2025
0c696eb
fix: removed debug logs
hentrymartin Oct 22, 2025
7efb759
fix: removed debug logs
hentrymartin Oct 22, 2025
d673dfb
fix: include shouldOpenOpportunity as valid field
hentrymartin Oct 22, 2025
43e1d43
fix: include shouldOpenOpportunity as valid field
hentrymartin Oct 22, 2025
e5e482c
fix: include shouldOpenOpportunity as valid field
hentrymartin Oct 22, 2025
b8862ab
fix: include shouldOpenOpportunity as valid field
hentrymartin Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ workflows:
- feature/top-262-projectid-non-mandatory
- TOP-2364
- PM-2097
- pm-2456

- "build-qa":
context: org-global
Expand Down
2 changes: 1 addition & 1 deletion src/common/prisma-helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ function convertChallengeSchemaToPrisma(currentUser, challenge) {
: Number(r.incrementalCoefficient),
aiWorkflowId: r.aiWorkflowId,
shouldOpenOpportunity: _.isNil(r.shouldOpenOpportunity)
? true
? false
: !!r.shouldOpenOpportunity,
createdAt: new Date(Date.now() + index),
};
Expand Down
3 changes: 2 additions & 1 deletion src/services/ChallengeService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ async function setDefaultReviewers(currentUser, data) {
scorecardId: Joi.string().required(),
isMemberReview: Joi.boolean().required(),
isAIReviewer: Joi.boolean().default(false),
shouldOpenOpportunity: Joi.boolean().default(true),
shouldOpenOpportunity: Joi.boolean().default(false),
memberReviewerCount: Joi.when("isMemberReview", {
is: true,
then: Joi.number().integer().min(1).required(),
Expand Down Expand Up @@ -3227,6 +3227,7 @@ function sanitizeChallenge(challenge) {
"fixedAmount",
"baseCoefficient",
"incrementalCoefficient",
"shouldOpenOpportunity",
"type",
"aiWorkflowId",
])
Expand Down