Skip to content

Expose challenge reviewer fixed amount payment field, remove ability to edit values #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2025
Merged

Expose challenge reviewer fixed amount payment field, remove ability to edit values #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/services/ChallengeService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@ async function getDefaultReviewers(currentUser, criteria) {
isMemberReview: r.isMemberReview,
memberReviewerCount: r.memberReviewerCount,
phaseName: r.phaseName,
fixedAmount: r.fixedAmount,
baseCoefficient: r.baseCoefficient,
incrementalCoefficient: r.incrementalCoefficient,
type: r.opportunityType,
Expand Down Expand Up @@ -292,6 +293,7 @@ async function setDefaultReviewers(currentUser, data) {
otherwise: Joi.forbidden(),
}),
phaseName: Joi.string().required(),
fixedAmount: Joi.number().min(0).optional().allow(null),
baseCoefficient: Joi.number().min(0).max(1).optional().allow(null),
incrementalCoefficient: Joi.number().min(0).max(1).optional().allow(null),
type: Joi.when("isMemberReview", {
Expand Down Expand Up @@ -369,6 +371,7 @@ async function setDefaultReviewers(currentUser, data) {
? null
: Number(r.memberReviewerCount),
phaseName: r.phaseName,
fixedAmount: _.isNil(r.fixedAmount) ? null : Number(r.fixedAmount),
baseCoefficient: _.isNil(r.baseCoefficient) ? null : Number(r.baseCoefficient),
incrementalCoefficient: _.isNil(r.incrementalCoefficient)
? null
Expand Down Expand Up @@ -1466,6 +1469,7 @@ async function createChallenge(currentUser, challenge, userToken) {
memberReviewerCount: r.memberReviewerCount,
// connect reviewers to the Phase model via its id
phaseId: phaseMap.get(r.phaseName),
fixedAmount: r.fixedAmount,
baseCoefficient: r.baseCoefficient,
incrementalCoefficient: r.incrementalCoefficient,
type: r.opportunityType,
Expand Down Expand Up @@ -1645,8 +1649,6 @@ createChallenge.schema = {
otherwise: Joi.forbidden(),
}),
phaseId: Joi.id().required(),
baseCoefficient: Joi.number().min(0).optional(),
incrementalCoefficient: Joi.number().min(0).optional(),
type: Joi.when("isMemberReview", {
is: true,
then: Joi.string().valid(_.values(ReviewOpportunityTypeEnum)).insensitive(),
Expand Down Expand Up @@ -2788,8 +2790,6 @@ updateChallenge.schema = {
otherwise: Joi.forbidden(),
}),
phaseId: Joi.id().required(),
baseCoefficient: Joi.number().min(0).optional().allow(null),
incrementalCoefficient: Joi.number().min(0).optional().allow(null),
type: Joi.when("isMemberReview", {
is: true,
then: Joi.string().valid(_.values(ReviewOpportunityTypeEnum)).insensitive(),
Expand Down Expand Up @@ -2987,6 +2987,7 @@ function sanitizeChallenge(challenge) {
"isAIReviewer",
"memberReviewerCount",
"phaseId",
"fixedAmount",
"baseCoefficient",
"incrementalCoefficient",
"type",
Expand Down