Skip to content

Commit d7c0538

Browse files
authored
Merge pull request #22 from topcoder-platform/challenge-reviewer-payment
Expose challenge reviewer fixed amount payment field, remove ability to edit values
2 parents 7251d11 + 1e2d266 commit d7c0538

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/services/ChallengeService.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -258,6 +258,7 @@ async function getDefaultReviewers(currentUser, criteria) {
258258
isMemberReview: r.isMemberReview,
259259
memberReviewerCount: r.memberReviewerCount,
260260
phaseName: r.phaseName,
261+
fixedAmount: r.fixedAmount,
261262
baseCoefficient: r.baseCoefficient,
262263
incrementalCoefficient: r.incrementalCoefficient,
263264
type: r.opportunityType,
@@ -292,6 +293,7 @@ async function setDefaultReviewers(currentUser, data) {
292293
otherwise: Joi.forbidden(),
293294
}),
294295
phaseName: Joi.string().required(),
296+
fixedAmount: Joi.number().min(0).optional().allow(null),
295297
baseCoefficient: Joi.number().min(0).max(1).optional().allow(null),
296298
incrementalCoefficient: Joi.number().min(0).max(1).optional().allow(null),
297299
type: Joi.when("isMemberReview", {
@@ -369,6 +371,7 @@ async function setDefaultReviewers(currentUser, data) {
369371
? null
370372
: Number(r.memberReviewerCount),
371373
phaseName: r.phaseName,
374+
fixedAmount: _.isNil(r.fixedAmount) ? null : Number(r.fixedAmount),
372375
baseCoefficient: _.isNil(r.baseCoefficient) ? null : Number(r.baseCoefficient),
373376
incrementalCoefficient: _.isNil(r.incrementalCoefficient)
374377
? null
@@ -1466,6 +1469,7 @@ async function createChallenge(currentUser, challenge, userToken) {
14661469
memberReviewerCount: r.memberReviewerCount,
14671470
// connect reviewers to the Phase model via its id
14681471
phaseId: phaseMap.get(r.phaseName),
1472+
fixedAmount: r.fixedAmount,
14691473
baseCoefficient: r.baseCoefficient,
14701474
incrementalCoefficient: r.incrementalCoefficient,
14711475
type: r.opportunityType,
@@ -1645,8 +1649,6 @@ createChallenge.schema = {
16451649
otherwise: Joi.forbidden(),
16461650
}),
16471651
phaseId: Joi.id().required(),
1648-
baseCoefficient: Joi.number().min(0).optional(),
1649-
incrementalCoefficient: Joi.number().min(0).optional(),
16501652
type: Joi.when("isMemberReview", {
16511653
is: true,
16521654
then: Joi.string().valid(_.values(ReviewOpportunityTypeEnum)).insensitive(),
@@ -2788,8 +2790,6 @@ updateChallenge.schema = {
27882790
otherwise: Joi.forbidden(),
27892791
}),
27902792
phaseId: Joi.id().required(),
2791-
baseCoefficient: Joi.number().min(0).optional().allow(null),
2792-
incrementalCoefficient: Joi.number().min(0).optional().allow(null),
27932793
type: Joi.when("isMemberReview", {
27942794
is: true,
27952795
then: Joi.string().valid(_.values(ReviewOpportunityTypeEnum)).insensitive(),
@@ -2987,6 +2987,7 @@ function sanitizeChallenge(challenge) {
29872987
"isAIReviewer",
29882988
"memberReviewerCount",
29892989
"phaseId",
2990+
"fixedAmount",
29902991
"baseCoefficient",
29912992
"incrementalCoefficient",
29922993
"type",

0 commit comments

Comments
 (0)