Merge pull request #52 from topcoder-platform/pm-2540_3

feat(PM-2540): added ai workflow id to default reviewer

Author: hentrymartin

prisma/migrations/20251112162335_aiworkflowid_in_def_challenge_reviewer/migration.sql

@@ -0,0 +1,10 @@
+/*
+  Warnings:
+
+  - You are about to drop the column `isAIReviewer` on the `DefaultChallengeReviewer` table. All the data in the column will be lost.
+
+*/
+-- AlterTable
+ALTER TABLE "DefaultChallengeReviewer" DROP COLUMN "isAIReviewer",
+ADD COLUMN     "aiWorkflowId" VARCHAR(14),
+ALTER COLUMN "scorecardId" DROP NOT NULL;

prisma/schema.prisma

@@ -649,7 +649,7 @@ model DefaultChallengeReviewer {
   trackId               String
   timelineTemplateId    String?
   // Reviewer configuration (mirrors ChallengeReviewer)
-  scorecardId           String
+  scorecardId           String?
   isMemberReview        Boolean
   memberReviewerCount   Int?
   phaseName             String
@@ -659,7 +659,7 @@ model DefaultChallengeReviewer {
   baseCoefficient           Float?
   incrementalCoefficient    Float?
   opportunityType       ReviewOpportunityTypeEnum?
-  isAIReviewer          Boolean?
+  aiWorkflowId          String?                    @db.VarChar(14)
   shouldOpenOpportunity Boolean                    @default(true)
 
   // Relations
@@ -724,4 +724,4 @@ model TimelineTemplatePhase {
 
   @@index([timelineTemplateId])
   @@index([timelineTemplateId, phaseId])
-}
+}

src/services/ChallengeService.js

@@ -300,7 +300,6 @@ async function getDefaultReviewers(currentUser, criteria) {
     incrementalCoefficient: r.incrementalCoefficient,
     type: r.opportunityType,
     aiWorkflowId: r.aiWorkflowId,
-    isAIReviewer: r.isAIReviewer,
     shouldOpenOpportunity: _.isBoolean(r.shouldOpenOpportunity) ? r.shouldOpenOpportunity : true,
   }));
 }
@@ -322,7 +321,6 @@ async function setDefaultReviewers(currentUser, data) {
           Joi.object().keys({
             scorecardId: Joi.string().required(),
             isMemberReview: Joi.boolean().required(),
-            isAIReviewer: Joi.boolean().default(false),
             shouldOpenOpportunity: Joi.boolean().default(true),
             memberReviewerCount: Joi.when("isMemberReview", {
               is: true,
@@ -403,7 +401,7 @@ async function setDefaultReviewers(currentUser, data) {
           timelineTemplateId: _.isNil(value.timelineTemplateId) ? null : value.timelineTemplateId,
           scorecardId: String(r.scorecardId),
           isMemberReview: !!r.isMemberReview,
-          isAIReviewer: !!r.isAIReviewer,
+          aiWorkflowId:_.isNil(r.aiWorkflowId) ? null : r.aiWorkflowId,
           memberReviewerCount: _.isNil(r.memberReviewerCount)
             ? null
             : Number(r.memberReviewerCount),
@@ -414,7 +412,6 @@ async function setDefaultReviewers(currentUser, data) {
             ? null
             : Number(r.incrementalCoefficient),
           opportunityType: r.type ? _.toUpper(r.type) : null,
-          aiWorkflowId: r.aiWorkflowId,
           shouldOpenOpportunity: _.isNil(r.shouldOpenOpportunity)
             ? true
             : !!r.shouldOpenOpportunity,
@@ -1712,7 +1709,6 @@ async function createChallenge(currentUser, challenge, userToken) {
           incrementalCoefficient: r.incrementalCoefficient,
           type: r.opportunityType,
           aiWorkflowId: r.aiWorkflowId,
-          isAIReviewer: r.isAIReviewer ?? false,
           shouldOpenOpportunity: _.isBoolean(r.shouldOpenOpportunity)
             ? r.shouldOpenOpportunity
             : true,
@@ -1880,7 +1876,6 @@ createChallenge.schema = {
         Joi.object().keys({
           scorecardId: Joi.string().required(),
           isMemberReview: Joi.boolean().required(),
-          isAIReviewer: Joi.boolean().default(false),
           shouldOpenOpportunity: Joi.boolean().default(true),
           memberReviewerCount: Joi.when("isMemberReview", {
             is: true,
@@ -3075,7 +3070,6 @@ updateChallenge.schema = {
           Joi.object().keys({
             scorecardId: Joi.string().required(),
             isMemberReview: Joi.boolean().required(),
-            isAIReviewer: Joi.boolean().default(false),
             shouldOpenOpportunity: Joi.boolean().default(true),
             memberReviewerCount: Joi.when("isMemberReview", {
               is: true,
@@ -3555,7 +3549,6 @@ function sanitizeChallenge(challenge) {
       _.pick(rv, [
         "scorecardId",
         "isMemberReview",
-        "isAIReviewer",
         "memberReviewerCount",
         "phaseId",
         "fixedAmount",

src/services/DefaultChallengeReviewerService.js

@@ -262,8 +262,8 @@ function normalizePayload(data = {}, isPartial = false) {
   } else if (!isPartial && _.isNil(data.opportunityType)) {
     normalized.opportunityType = null;
   }
-  if (shouldAssign(data.isAIReviewer)) {
-    normalized.isAIReviewer = data.isAIReviewer;
+  if (shouldAssign(data.aiWorkflowId)) {
+    normalized.aiWorkflowId = data.aiWorkflowId;
   }
   if (shouldAssign(data.shouldOpenOpportunity)) {
     normalized.shouldOpenOpportunity = data.shouldOpenOpportunity;
@@ -325,7 +325,7 @@ createDefaultChallengeReviewer.schema = {
       typeId: Joi.id().required(),
       trackId: Joi.id().required(),
       timelineTemplateId: Joi.optionalId().allow(null),
-      scorecardId: Joi.string().required(),
+      scorecardId: Joi.string().optional(),
       isMemberReview: Joi.boolean().required(),
       memberReviewerCount: Joi.when("isMemberReview", {
         is: true,
@@ -338,7 +338,11 @@ createDefaultChallengeReviewer.schema = {
       baseCoefficient: Joi.number().min(0).max(1).allow(null),
       incrementalCoefficient: Joi.number().min(0).max(1).allow(null),
       opportunityType: Joi.string().valid(..._.values(ReviewOpportunityTypeEnum)).insensitive(),
-      isAIReviewer: Joi.boolean().required(),
+      aiWorkflowId: Joi.when("isMemberReview", {
+        is: false,
+        then: Joi.string().required(),
+        otherwise: Joi.valid(null),
+      }),
       shouldOpenOpportunity: Joi.boolean().required(),
     })
     .required(),
@@ -404,7 +408,7 @@ fullyUpdateDefaultChallengeReviewer.schema = {
       typeId: Joi.id().required(),
       trackId: Joi.id().required(),
       timelineTemplateId: Joi.optionalId().allow(null),
-      scorecardId: Joi.string().required(),
+      scorecardId: Joi.string().optional(),
       isMemberReview: Joi.boolean().required(),
       memberReviewerCount: Joi.when("isMemberReview", {
         is: true,
@@ -417,7 +421,11 @@ fullyUpdateDefaultChallengeReviewer.schema = {
       baseCoefficient: Joi.number().min(0).max(1).allow(null),
       incrementalCoefficient: Joi.number().min(0).max(1).allow(null),
       opportunityType: Joi.string().valid(..._.values(ReviewOpportunityTypeEnum)).insensitive(),
-      isAIReviewer: Joi.boolean().required(),
+      aiWorkflowId: Joi.when("isMemberReview", {
+        is: false,
+        then: Joi.string().required(),
+        otherwise: Joi.valid(null),
+      }),
       shouldOpenOpportunity: Joi.boolean().required(),
     })
     .required(),
@@ -516,7 +524,7 @@ partiallyUpdateDefaultChallengeReviewer.schema = {
         .valid(..._.values(ReviewOpportunityTypeEnum))
         .insensitive()
         .allow(null),
-      isAIReviewer: Joi.boolean(),
+      aiWorkflowId: Joi.string(),
       shouldOpenOpportunity: Joi.boolean(),
     })
     .required(),