ExternalId for skill cannot be a required field because in some scenarios, the skill is not coming from an external source but directly fed into ubahn

callmekatootie · callmekatootie · commit bedfd3f505c0 · 2020-08-04T19:38:58.000+05:30
diff --git a/src/modules/skill/service.js b/src/modules/skill/service.js
@@ -11,7 +11,7 @@ const methods = helper.getServiceMethods(
     skillProviderId: joi.string().required(),
     name: joi.string().required(),
     uri: joi.string(),
-    externalId: joi.string().required()
+    externalId: joi.string()
   },
   {
     skillProviderId: joi.string(),

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ const methods = helper.getServiceMethods(`
`11`	`11`	`skillProviderId: joi.string().required(),`
`12`	`12`	`name: joi.string().required(),`
`13`	`13`	`uri: joi.string(),`
`14`		`- externalId: joi.string().required()`
	`14`	`+ externalId: joi.string()`
`15`	`15`	`},`
`16`	`16`	`{`
`17`	`17`	`skillProviderId: joi.string(),`