fix empty components paramter case

Author: fireice.topcoder

actions/srmRoundComponentsAndTerms.js

@@ -59,7 +59,7 @@ function checkDefinedNonNegativeInteger(value, name, error, helper) {
  * @param callback the callback method
  */
 function checkComponents(api, dbConnectionMap, components, callback) {
-    var helper = api.helper, error = helper.checkArray(components, "components", false), existingComponentDivisionIds = [];
+    var helper = api.helper, error = helper.checkArray(components, "components", true), existingComponentDivisionIds = [];
     if (error) {
         callback(error);
         return;
@@ -202,7 +202,7 @@ var setRoundComponents = function (api, connection, dbConnectionMap, next) {
     var helper = api.helper,
         sqlParams = {},
         roundId = Number(connection.params.roundId),
-        components = connection.params.components;
+        components = connection.params.components || [];
 
     async.waterfall([
         function (cb) {
@@ -348,8 +348,8 @@ exports.setRoundComponents = {
     name: "setRoundComponents",
     description: "Set Round Components",
     inputs: {
-        required: ['roundId', 'components'],
-        optional: []
+        required: ['roundId'],
+        optional: ['components']
     },
     blockedConnectionTypes: [],
     outputExample: {},

test/test.srmRoundComponentsAndTerms.js

@@ -345,6 +345,26 @@ describe('SRM Round Components And Terms APIs', function () {
     });
 
     describe('Valid test', function () {
+        it("Valid set components.", function(done) {
+            var validRequest = {};
+            createPostRequest("/v2/data/srm/rounds/13673/components", 'heffan').expect(200).send(validRequest).end(function (err, res) {
+                if (err) {
+                    done(err);
+                    return;
+                }
+                assert.equal(res.body.success, true, "Invalid response detail");
+                var sql = "* from round_component where round_id = 13673 order by component_id";
+                testHelper.runSqlSelectQuery(sql, "informixoltp", function (err, result) {
+                    if (err) {
+                        done(err);
+                        return;
+                    }
+                    assert.equal(result.length, 0, "All components should be removed!");
+                });
+                done();
+            });
+        });
+
         it("Valid set components.", function (done) {
             var validRequest = {"components": [{"componentId": 2020, "points": 250, "divisionId": 1, "difficultyId": 1, "openOrder": 1, "submitOrder": 1},
                 {"componentId": 2021, "points": 500, "divisionId": 2, "difficultyId": 2, "openOrder": 1, "submitOrder": 1}]};