Merge pull request #429 from appirio-tech/SUP-612-fix-inactive-users-can-register

inactive users shouldn't be allowed to register for challenges

Author: thabofletcher

actions/challengeRegistration.js

@@ -869,9 +869,12 @@ exports.registerChallenge = {
                 if (error) {
                     console.log("error: " +  error);
                     cb(error);
-                } else {
-                    console.log("error11: " +  error);
-                    api.dataAccess.executeQuery('check_challenge_exists', {challengeId: challengeId}, connection.dbConnectionMap, cb);
+                } else {                   
+                    api.helper.checkUserActivated(connection.caller.handle, api, connection.dbConnectionMap, function (err, inactive) {
+                        var fail = err || inactive;
+                        if (fail) cb(fail);
+                        else api.dataAccess.executeQuery('check_challenge_exists', {challengeId: challengeId}, connection.dbConnectionMap, cb);
+                    });                    
                 }
             }, function (result, cb) {
                 if (result.length > 0) {

apiary.apib

@@ -9946,7 +9946,7 @@ Request
         }
 
 ## Register for a software/studio challenge [/challenges/{challengeId}/register]
-### Register for a software/studio challenge [GET]
+### Register for a software/studio challenge [POST]
 
 + Parameters
     + challengeId (required, number, `1234567`) ... The challenge for which to register