Merge pull request #142 from skyhit/default_assembly_reviewer_to_2

ajefts · web-flow · commit df68b8193966 · 2016-08-17T16:39:14.000-04:00
make default reviewer number for assembly to 2
diff --git a/services/project_services/src/java/main/com/topcoder/project/service/impl/ProjectServicesImpl.java b/services/project_services/src/java/main/com/topcoder/project/service/impl/ProjectServicesImpl.java
@@ -5361,15 +5361,12 @@ else if (p.getPhaseType().getName().equals("Review"))
                         ) {
                     // 1) copilot posting 2) studio 3) bug hunt 4) code with auto assigned review only requires one reviewer.
                     p.setAttribute("Reviewer Number", "1");
-                } else if(projectHeader.getProjectCategory().getId() == ProjectCategory.CODE.getId() &&
-                                projectHeader.getAutoAssignReviewerId() == 0) {
+                } else if((projectHeader.getProjectCategory().getId() == ProjectCategory.CODE.getId() && projectHeader.getAutoAssignReviewerId() == 0)
+                        || projectHeader.getProjectCategory().getId() == ProjectCategory.ASSEMBLY.getId()) {
                     p.setAttribute("Reviewer Number", "2");
                 } else {
                     p.setAttribute("Reviewer Number", "3");
                 }
-
-
-                
             }
 			else if (p.getPhaseType().getName().equals("Secondary Reviewer Review"))
             {

Original file line number	Diff line number	Diff line change
`@@ -5361,15 +5361,12 @@ else if (p.getPhaseType().getName().equals("Review"))`
`5361`	`5361`	`) {`
`5362`	`5362`	`// 1) copilot posting 2) studio 3) bug hunt 4) code with auto assigned review only requires one reviewer.`
`5363`	`5363`	`p.setAttribute("Reviewer Number", "1");`
`5364`		`- } else if(projectHeader.getProjectCategory().getId() == ProjectCategory.CODE.getId() &&`
`5365`		`- projectHeader.getAutoAssignReviewerId() == 0) {`
	`5364`	`+ } else if((projectHeader.getProjectCategory().getId() == ProjectCategory.CODE.getId() && projectHeader.getAutoAssignReviewerId() == 0)`
	`5365`	`+ \|\| projectHeader.getProjectCategory().getId() == ProjectCategory.ASSEMBLY.getId()) {`
`5366`	`5366`	`p.setAttribute("Reviewer Number", "2");`
`5367`	`5367`	`} else {`
`5368`	`5368`	`p.setAttribute("Reviewer Number", "3");`
`5369`	`5369`	`}`
`5370`		`-`
`5371`		`-`
`5372`		`-`
`5373`	`5370`	`}`
`5374`	`5371`	`else if (p.getPhaseType().getName().equals("Secondary Reviewer Review"))`
`5375`	`5372`	`{`