Skip to content
This repository was archived by the owner on Jan 23, 2025. It is now read-only.

Commit 5764ffc

Browse files
authored
Merge pull request #355 from deedee/jwttoken_update
Use JWT_V3_COOKIE_KEY
2 parents 1d270e5 + 774a821 commit 5764ffc

File tree

9 files changed

+11
-11
lines changed

9 files changed

+11
-11
lines changed

src/java/main/com/topcoder/direct/services/configs/ServerConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,5 +55,5 @@ public class ServerConfiguration extends ApplicationServer {
5555
*
5656
* @since 1.1
5757
*/
58-
public static String JWT_COOKIE_KEY = bundle.getProperty("JWT_COOKIE_KEY", "tcjwt");
58+
public static String JWT_V3_COOKIE_KEY = bundle.getProperty("JWT_V3_COOKIE_KEY", "v3jwt");
5959
}

src/java/main/com/topcoder/direct/services/view/action/ServiceBackendDataTablesAction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,7 @@ protected JsonNode getJsonResultFromAPI(URI apiEndPoint) throws Exception {
320320
HttpGet getRequest = new HttpGet(apiEndPoint);
321321

322322
String token = DirectUtils.getCookieFromRequest(ServletActionContext.getRequest(),
323-
ServerConfiguration.JWT_COOKIE_KEY).getValue();
323+
ServerConfiguration.JWT_V3_COOKIE_KEY).getValue();
324324

325325
getRequest.setHeader(HttpHeaders.AUTHORIZATION,
326326
"Bearer " + token);

src/java/main/com/topcoder/direct/services/view/action/contest/launch/GetGroupMemberAction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ private RestResult<GroupMember> getGroupMemberByGid(Long gid) throws Exception {
186186
URI groupApiEndpointUri = new URI(String.format(groupApiEndpoint, gid));
187187
HttpGet request = new HttpGet(groupApiEndpointUri);
188188
String jwtToken = DirectUtils.getCookieFromRequest(ServletActionContext.getRequest(),
189-
ServerConfiguration.JWT_COOKIE_KEY).getValue();
189+
ServerConfiguration.JWT_V3_COOKIE_KEY).getValue();
190190

191191
request.setHeader(HttpHeaders.AUTHORIZATION, "Bearer " + jwtToken);
192192
request.addHeader(HttpHeaders.ACCEPT, "application/json");

src/java/main/com/topcoder/direct/services/view/interceptors/AuthenticationInterceptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ public String intercept(ActionInvocation invocation) throws Exception {
286286
User user = auth.getActiveUser();
287287

288288
Cookie jwtCookie = DirectUtils.getCookieFromRequest(ServletActionContext.getRequest(),
289-
ServerConfiguration.JWT_COOKIE_KEY);
289+
ServerConfiguration.JWT_V3_COOKIE_KEY);
290290

291291
if (jwtCookie == null) {
292292
return loginPageName;

src/java/main/com/topcoder/direct/services/view/processor/security/LoginProcessor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ public void processRequest(LoginAction action) {
131131
// add session cookie, use -1 for expiration time
132132
log.info("Signed JWT: " + sign);
133133
DirectUtils.addDirectCookie(ServletActionContext.getResponse(),
134-
ServerConfiguration.JWT_COOKIE_KEY, sign, -1);
134+
ServerConfiguration.JWT_V3_COOKIE_KEY, sign, -1);
135135

136136
} catch (AuthenticationException e) {
137137
log.error("User " + username + " failed to authenticate successfully due to invalid credentials", e);

src/java/main/com/topcoder/direct/services/view/processor/security/MockLoginProcessor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ public void processRequest(LoginAction action) {
211211
log.info("SIgned JWT: " + sign);
212212
// add session cookie, use -1 for expiration time
213213
DirectUtils.addDirectCookie(ServletActionContext.getResponse(),
214-
ServerConfiguration.JWT_COOKIE_KEY, sign, -1);
214+
ServerConfiguration.JWT_V3_COOKIE_KEY, sign, -1);
215215
} catch (Exception e) {
216216
log.error("User " + username + " could not set cookie", e);
217217
log.error(e.getMessage() + e.getCause());

src/java/main/com/topcoder/direct/services/view/util/DirectUtils.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3823,7 +3823,7 @@ public static Set<ProjectGroup> getGroupsFromApi(TCSubject tcSubject, String end
38233823
HttpGet getRequest = new HttpGet(uri.build());
38243824
logger.info("Getting Group with thi uri: " + uri.build().toString());
38253825

3826-
String v3Token = getCookieFromRequest(getServletRequest(), ServerConfiguration.JWT_COOKIE_KEY).getValue();
3826+
String v3Token = getCookieFromRequest(getServletRequest(), ServerConfiguration.JWT_V3_COOKIE_KEY).getValue();
38273827

38283828
getRequest.setHeader(HttpHeaders.AUTHORIZATION, "Bearer " + v3Token);
38293829

@@ -3874,4 +3874,4 @@ public static Set<ProjectGroup> getGroups(TCSubject tcSubject, String endpoint)
38743874
}
38753875
return projectGroups;
38763876
}
3877-
}
3877+
}

token.properties.docker

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@
335335
#####################################
336336
# Direct API #
337337
#####################################
338-
@ApplicationServer.JWT_COOKIE_KEY@=tcjwt_vm
338+
@ApplicationServer.JWT_V3_COOKIE_KEY@=v3jwt
339339

340340
@memberSearchApiUrl@=https://tc-api.cloud.topcoder.com:8443/v3/members/_suggest/
341341
@groupMemberSearchApiUrl@=https://cockpit.cloud.topcoder.com/direct/group/member?handle=

token.properties.example

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@
301301
@ApplicationServer.SSO_HASH_SECRET@=
302302
@ApplicationServer.SSO_DOMAIN@=topcoder.com
303303

304-
@ApplicationServer.JWT_COOKIE_KEY@=tcjwt
304+
@ApplicationServer.JWT_V3_COOKIE_KEY@=tcjwt
305305

306306
#######################################
307307
# securityGroupApplicationContext.xml #
@@ -399,4 +399,4 @@
399399
@groupMemberApiUrl@=http://172.18.0.1:8080/v3/groups/%d/members
400400
@directChallengeServicesApiUrl@=http://api.topcoder-dev.com/v3/direct/challenges
401401
@authorizationUrl@=http://api.topcoder-dev.com/v3/authorizations
402-
@userGroupsApiEndpoint@=http://172.18.0.1:8080/v3/groups
402+
@userGroupsApiEndpoint@=http://172.18.0.1:8080/v3/groups

0 commit comments

Comments
 (0)