fixing linting errors

Author: Parth Shah

app/directives/tc-fp-file-input/tc-fp-file-input.directive.js

@@ -33,36 +33,35 @@ import _ from 'lodash'
         }
         // set extensions
         if (scope.fieldId.indexOf('ZIP') > -1) {
-          scope.extensions = ".zip"
+          scope.extensions = '.zip'
         } else if (scope.fieldId.indexOf('DESIGN_COVER') > -1) {
-          scope.extensions = ".png,.jpeg,.jpg,.bmp"
+          scope.extensions = '.png,.jpeg,.jpg,.bmp'
         }
 
         // set default services
-        scope.fpServices = scope.fpServices || "COMPUTER,GOOGLE_DRIVE,BOX,DROPBOX"
+        scope.fpServices = scope.fpServices || 'COMPUTER,GOOGLE_DRIVE,BOX,DROPBOX'
         scope.fpContainer = CONSTANTS.FILE_PICKER_SUBMISSION_CONTAINER_NAME || 'submission-staging-dev'
 
         // set max size
-        scope.maxSize = 500*1024*1024
+        scope.maxSize = 500 * 1024 * 1024
 
-        var key, value;
-        /*
-         *pass original event
-        */
+        var key, value
+          /*
+           *pass original event
+           */
         element.bind('change', function(event) {
-            event.preventDefault()
-            scope.onSuccess(event.originalEvent || event);
-            $rootScope.$apply()
-        });
-        element = element.length ? element[0] : element;
-        for (key in attrs.$attr){
-            value = attrs.$attr[key]
-            element.setAttribute(value, attrs[key])
+          event.preventDefault()
+          scope.onSuccess(event.originalEvent || event)
+          $rootScope.$apply()
+        })
+        element = element.length ? element[0] : element
+        for (key in attrs.$attr) {
+          value = attrs.$attr[key]
+          element.setAttribute(value, attrs[key])
         }
         filepickerService.constructWidget(element)
 
-        scope.onSuccess = function (event) {
-          debugger
+        scope.onSuccess = function(event) {
           var fpFile = event.fpfile
           var _file = {
             name: scope.filename || fpFile.filename,
@@ -72,7 +71,10 @@ import _ from 'lodash'
             mimetype: fpFile.mimetype
           }
           scope.ngModel = _file
-          scope.setFileReference({file: _file, fieldId: scope.fieldId})
+          scope.setFileReference({
+            file: _file,
+            fieldId: scope.fieldId
+          })
         }
       }
     }

app/services/submissions.service.js

@@ -24,12 +24,8 @@ import angular from 'angular'
       return api.all('submissions').customPOST(body)
       .then(function(response) {
         //progressCallback.call(progressCallback, 'PREPARE', 100)
-
         // uploadSubmissionFileToS3(response, response.data.files, files, progressCallback)
-
-        console.log(response);
-
-        processSubmission(response, progressCallback);
+        processSubmission(response, progressCallback)
       })
       .catch(function(err) {
         logger.error('Could not get presigned url', err)
@@ -136,7 +132,7 @@ import angular from 'angular'
 
         progressCallback.call(progressCallback, 'FINISH', 100)
 
-        return response;
+        return response
       })
       .catch(function(err) {
         logger.error('Could not start processing', err)

app/submissions/submit-design-files/submit-design-files.controller.js

@@ -12,7 +12,6 @@ import _ from 'lodash'
     if (!challengeToSubmitTo.challenge) { return }
 
     var vm = this
-    var files = {}
     var fileUploadProgress = {}
     vm.urlRegEx = new RegExp(/^(http(s?):\/\/)?(www\.)?[a-zA-Z0-9\.\-\_]+(\.[a-zA-Z]{2,3})+(\/[a-zA-Z0-9\_\-\s\.\/\?\%\#\&\=]*)?$/)
     vm.rankRegEx = new RegExp(/^[1-9]\d*$/)
@@ -148,16 +147,12 @@ import _ from 'lodash'
 
       vm.submissionsBody.data.fonts = processedFonts
       SubmissionsService.startSubmission(vm.submissionsBody, updateProgress)
-      .then(function(newSubmission) {
-        logger.debug("New Submission: ", newSubmission)
-        //SubmissionsService.processSubmission(newSubmission, updateProgress)
-      })
       .then(function(processedSubmission) {
-        logger.debug("Processed Submission: ", processedSubmission)
-
+        logger.debug('Processed Submission: ', processedSubmission)
       })
       .catch(function(err) {
-        logger.error("Submission processing failed ", err)
+        logger.error('Submission processing failed ', err)
+        // TODO handle error
       })
     }
 

webpack.config.js

@@ -1,5 +1,4 @@
 require('./node_modules/coffee-script/register')
-var BowerWebpackPlugin = require('bower-webpack-plugin')
 
 const CI = process.env.TRAVIS_BRANCH
 
@@ -30,16 +29,7 @@ const config = require('appirio-tech-webpack-config')({
   favicon: './assets/images/favicon.ico',
   uglifyOptions: {
     mangle: { except: ['Auth0'] }
-  },
-  plugins: [
-    new BowerWebpackPlugin({
-      moduleDirectories: ["bower_components"],
-      manifestFiles: "bower.json",
-      includes: /.*/,
-      excludes: [],
-      searchResolveModulesDirectories: true
-    })
-  ]
+  }  
 })
 
 if (CI) config.output.publicPath = process.env.ASSET_PREFIX