Use case changed instead of rename in rule names

emmetog · emmetog · commit 931d81fef379 · 2018-02-19T07:51:39.000Z
diff --git a/docs/Ruleset.md b/docs/Ruleset.md
@@ -15,7 +15,7 @@ V070 | MINOR | Function parameter typing removed
 V071 | MINOR | Function parameter default added
 V072 | MAJOR | Function parameter default removed
 V073 | MINOR | Function parameter default value changed
-V160 | PATCH | Function renamed (case only)
+V160 | PATCH | Function name case changed
 
 # Classes
 
@@ -71,10 +71,10 @@ V096 | PATCH | Class private method parameter default removed
 V097 | MAJOR | Class public method parameter default value changed
 V098 | MAJOR | Class protected method parameter default value changed
 V099 | PATCH | Class private method parameter default value changed
-V150 | PATCH | Class public method renamed (case only)
-V156 | PATCH | Class protected method renamed (case only)
-V157 | PATCH | Class private method renamed (case only)
-V154 | PATCH | Class renamed (case only)
+V150 | PATCH | Class public method name case changed
+V156 | PATCH | Class protected method name case changed
+V157 | PATCH | Class private method name case changed
+V154 | PATCH | Class name case changed
 VXXX | MAJOR | *Final class public method parameter added*
 VXXX | MAJOR | *Final class protected method parameter added*
 VXXX | PATCH | *Final class private method parameter added*
@@ -114,8 +114,8 @@ V076 | MAJOR | Interface method parameter typing removed
 V077 | MINOR | Interface method parameter default added
 V078 | MAJOR | Interface method parameter default removed
 V079 | MAJOR | Interface method parameter default value changed
-V151 | PATCH | Interface method renamed (case only)
-V153 | PATCH | Interface renamed (case only)
+V151 | PATCH | Interface method name case changed
+V153 | PATCH | Interface name case changed
 
 # Trait
 
@@ -165,10 +165,10 @@ V114 | MAJOR | Trait private method parameter default removed
 V115 | MAJOR | Trait public method parameter default value changed
 V116 | MAJOR | Trait protected method parameter default value changed
 V117 | MAJOR | Trait private method parameter default value changed
-V152 | PATCH | Trait public method renamed (case only)
-V158 | PATCH | Trait protected method renamed (case only)
-V159 | PATCH | Trait private method renamed (case only)
-V155 | PATCH | Trait renamed (case only)
+V152 | PATCH | Trait public method name case changed
+V158 | PATCH | Trait protected method name case changed
+V159 | PATCH | Trait private method name case changed
+V155 | PATCH | Trait name case changed
 
 # To classify
 
diff --git a/src/PHPSemVerChecker/Analyzer/ClassMethodAnalyzer.php b/src/PHPSemVerChecker/Analyzer/ClassMethodAnalyzer.php
@@ -92,7 +92,7 @@ public function analyze(Stmt $contextBefore, Stmt $contextAfter)
 			// Leave non-strict comparison here
 			if ($methodBefore != $methodAfter) {
 
-				// Detect method renamed case only.
+				// Detect method case changed.
 				// If we entered this section then the normalized names (lowercase) were equal.
 				if ($methodBefore->name !== $methodAfter->name) {
 					$report->add(
diff --git a/src/PHPSemVerChecker/Operation/ClassCaseChanged.php b/src/PHPSemVerChecker/Operation/ClassCaseChanged.php
@@ -13,7 +13,7 @@ class ClassCaseChanged extends ClassOperationDelta {
 	/**
 	 * @var string
 	 */
-	protected $reason = 'Class was renamed (case only).';
+	protected $reason = 'Class name case was changed.';
 	/**
 	 * @var string
 	 */
diff --git a/src/PHPSemVerChecker/Operation/ClassMethodCaseChanged.php b/src/PHPSemVerChecker/Operation/ClassMethodCaseChanged.php
@@ -15,5 +15,5 @@ class ClassMethodCaseChanged extends ClassMethodOperationDelta
 	/**
 	 * @var string
 	 */
-	protected $reason = 'Method has been renamed (case only).';
+	protected $reason = 'Method name case was changed.';
 }
diff --git a/src/PHPSemVerChecker/Operation/FunctionCaseChanged.php b/src/PHPSemVerChecker/Operation/FunctionCaseChanged.php
@@ -11,5 +11,5 @@ class FunctionCaseChanged extends FunctionOperationDelta
 	/**
 	 * @var string
 	 */
-	protected $reason = 'Function renamed (case only).';
+	protected $reason = 'Function name case was changed.';
 }
diff --git a/src/PHPSemVerChecker/Operation/InterfaceCaseChanged.php b/src/PHPSemVerChecker/Operation/InterfaceCaseChanged.php
@@ -10,5 +10,5 @@ class InterfaceCaseChanged extends InterfaceOperationDelta {
 	/**
 	 * @var string
 	 */
-	protected $reason = 'Interface was renamed (case only).';
+	protected $reason = 'Interface name case was changed.';
 }
diff --git a/src/PHPSemVerChecker/Operation/TraitCaseChanged.php b/src/PHPSemVerChecker/Operation/TraitCaseChanged.php
@@ -13,5 +13,5 @@ class TraitCaseChanged extends TraitOperationDelta {
 	/**
 	 * @var string
 	 */
-	protected $reason = 'Trait was renamed (case only).';
+	protected $reason = 'Trait name case was changed.';
 }
diff --git a/tests/PHPSemVerChecker/Analyzer/ClassAnalyzerTest.php b/tests/PHPSemVerChecker/Analyzer/ClassAnalyzerTest.php
@@ -63,7 +63,7 @@ public function testClassRemoved()
 		$this->assertSame('tmp', $report[$context][$expectedLevel][0]->getTarget());
 	}
 
-	public function testClassRenamedCaseOnly()
+	public function testClassCaseChanged()
 	{
 		$before = new Registry();
 		$after = new Registry();
@@ -78,7 +78,7 @@ public function testClassRenamedCaseOnly()
 		$expectedLevel = Level::PATCH;
 		Assert::assertDifference($report, $context, $expectedLevel);
 		$this->assertSame('V154', $report[$context][$expectedLevel][0]->getCode());
-		$this->assertSame('Class was renamed (case only).', $report[$context][$expectedLevel][0]->getReason());
+		$this->assertSame('Class name case was changed.', $report[$context][$expectedLevel][0]->getReason());
 		$this->assertSame('TestClass', $report[$context][$expectedLevel][0]->getTarget());
 	}
 }
diff --git a/tests/PHPSemVerChecker/Analyzer/ClassMethodAnalyzerTest.php b/tests/PHPSemVerChecker/Analyzer/ClassMethodAnalyzerTest.php
@@ -744,7 +744,7 @@ public function testClassMethodCaseChangeChanged($context, $visibility, $code)
 
 		$expectedLevel = LevelMapping::getLevelForCode($code);
 		$this->assertSame($code, $report[$context][$expectedLevel][0]->getCode());
-		$this->assertSame(sprintf('[%s] Method has been renamed (case only).', $visibility), $report[$context][$expectedLevel][0]->getReason());
+		$this->assertSame(sprintf('[%s] Method name case was changed.', $visibility), $report[$context][$expectedLevel][0]->getReason());
 	}
 
 	public function providerCaseChanged()
diff --git a/tests/PHPSemVerChecker/Analyzer/FunctionAnalyzerTest.php b/tests/PHPSemVerChecker/Analyzer/FunctionAnalyzerTest.php
@@ -414,7 +414,7 @@ public function testFunctionCaseChanged()
 		$expectedLevel = Level::PATCH;
 		Assert::assertDifference($report, 'function', $expectedLevel);
 		$this->assertSame('V160', $report['function'][$expectedLevel][0]->getCode());
-		$this->assertSame('Function renamed (case only).', $report['function'][$expectedLevel][0]->getReason());
+		$this->assertSame('Function name case was changed.', $report['function'][$expectedLevel][0]->getReason());
 		$this->assertSame('someFunctionName', $report['function'][$expectedLevel][0]->getTarget());
 	}
 }
diff --git a/tests/PHPSemVerChecker/Analyzer/InterfaceAnalyzerTest.php b/tests/PHPSemVerChecker/Analyzer/InterfaceAnalyzerTest.php
@@ -81,6 +81,6 @@ public function testInterfaceCaseChanged()
 		$expectedLevel = Level::PATCH;
 		Assert::assertDifference($report, $context, $expectedLevel);
 		$this->assertSame('V153', $report[$context][$expectedLevel][0]->getCode());
-		$this->assertSame('Interface was renamed (case only).', $report[$context][$expectedLevel][0]->getReason());
+		$this->assertSame('Interface name case was changed.', $report[$context][$expectedLevel][0]->getReason());
 	}
 }
diff --git a/tests/PHPSemVerChecker/Analyzer/TraitAnalyzerTest.php b/tests/PHPSemVerChecker/Analyzer/TraitAnalyzerTest.php
@@ -78,7 +78,7 @@ public function testTraitCaseChanged()
 		$expectedLevel = Level::PATCH;
 		Assert::assertDifference($report, $context, $expectedLevel);
 		$this->assertSame('V155', $report[$context][$expectedLevel][0]->getCode());
-		$this->assertSame('Trait was renamed (case only).', $report[$context][$expectedLevel][0]->getReason());
+		$this->assertSame('Trait name case was changed.', $report[$context][$expectedLevel][0]->getReason());
 		$this->assertSame('testtrait', $report[$context][$expectedLevel][0]->getTarget());
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -15,5 +15,5 @@ class ClassMethodCaseChanged extends ClassMethodOperationDelta`
`15`	`15`	`/**`
`16`	`16`	`* @var string`
`17`	`17`	`*/`
`18`		`- protected $reason = 'Method has been renamed (case only).';`
	`18`	`+ protected $reason = 'Method name case was changed.';`
`19`	`19`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,5 +11,5 @@ class FunctionCaseChanged extends FunctionOperationDelta`
`11`	`11`	`/**`
`12`	`12`	`* @var string`
`13`	`13`	`*/`
`14`		`- protected $reason = 'Function renamed (case only).';`
	`14`	`+ protected $reason = 'Function name case was changed.';`
`15`	`15`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10,5 +10,5 @@ class InterfaceCaseChanged extends InterfaceOperationDelta {`
`10`	`10`	`/**`
`11`	`11`	`* @var string`
`12`	`12`	`*/`
`13`		`- protected $reason = 'Interface was renamed (case only).';`
	`13`	`+ protected $reason = 'Interface name case was changed.';`
`14`	`14`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,5 +13,5 @@ class TraitCaseChanged extends TraitOperationDelta {`
`13`	`13`	`/**`
`14`	`14`	`* @var string`
`15`	`15`	`*/`
`16`		`- protected $reason = 'Trait was renamed (case only).';`
	`16`	`+ protected $reason = 'Trait name case was changed.';`
`17`	`17`	`}`
Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ public function testClassRemoved()`
`63`	`63`	`$this->assertSame('tmp', $report[$context][$expectedLevel][0]->getTarget());`
`64`	`64`	`}`
`65`	`65`
`66`		`- public function testClassRenamedCaseOnly()`
	`66`	`+ public function testClassCaseChanged()`
`67`	`67`	`{`
`68`	`68`	`$before = new Registry();`
`69`	`69`	`$after = new Registry();`
`@@ -78,7 +78,7 @@ public function testClassRenamedCaseOnly()`
`78`	`78`	`$expectedLevel = Level::PATCH;`
`79`	`79`	`Assert::assertDifference($report, $context, $expectedLevel);`
`80`	`80`	`$this->assertSame('V154', $report[$context][$expectedLevel][0]->getCode());`
`81`		`- $this->assertSame('Class was renamed (case only).', $report[$context][$expectedLevel][0]->getReason());`
	`81`	`+ $this->assertSame('Class name case was changed.', $report[$context][$expectedLevel][0]->getReason());`
`82`	`82`	`$this->assertSame('TestClass', $report[$context][$expectedLevel][0]->getTarget());`
`83`	`83`	`}`
`84`	`84`	`}`
Original file line number	Diff line number	Diff line change
`@@ -744,7 +744,7 @@ public function testClassMethodCaseChangeChanged($context, $visibility, $code)`
`744`	`744`
`745`	`745`	`$expectedLevel = LevelMapping::getLevelForCode($code);`
`746`	`746`	`$this->assertSame($code, $report[$context][$expectedLevel][0]->getCode());`
`747`		`- $this->assertSame(sprintf('[%s] Method has been renamed (case only).', $visibility), $report[$context][$expectedLevel][0]->getReason());`
	`747`	`+ $this->assertSame(sprintf('[%s] Method name case was changed.', $visibility), $report[$context][$expectedLevel][0]->getReason());`
`748`	`748`	`}`
`749`	`749`
`750`	`750`	`public function providerCaseChanged()`
Original file line number	Diff line number	Diff line change
`@@ -414,7 +414,7 @@ public function testFunctionCaseChanged()`
`414`	`414`	`$expectedLevel = Level::PATCH;`
`415`	`415`	`Assert::assertDifference($report, 'function', $expectedLevel);`
`416`	`416`	`$this->assertSame('V160', $report['function'][$expectedLevel][0]->getCode());`
`417`		`- $this->assertSame('Function renamed (case only).', $report['function'][$expectedLevel][0]->getReason());`
	`417`	`+ $this->assertSame('Function name case was changed.', $report['function'][$expectedLevel][0]->getReason());`
`418`	`418`	`$this->assertSame('someFunctionName', $report['function'][$expectedLevel][0]->getTarget());`
`419`	`419`	`}`
`420`	`420`	`}`