Generalize unary operations on classes, interfaces, properties and traits.

Author: tomzx

src/PHPSemVerChecker/Operation/ClassAdded.php

@@ -2,10 +2,7 @@
 
 namespace PHPSemVerChecker\Operation;
 
-use PhpParser\Node\Stmt\Class_;
-use PHPSemVerChecker\Node\Statement\Class_ as PClass;
-
-class ClassAdded extends Operation {
+class ClassAdded extends ClassOperationUnary {
 	/**
 	 * @var string
 	 */
@@ -14,46 +11,4 @@ class ClassAdded extends Operation {
 	 * @var string
 	 */
 	protected $reason = 'Class was added.';
-	/**
-	 * @var string
-	 */
-	protected $fileAfter;
-	/**
-	 * @var \PhpParser\Node\Stmt\Class_
-	 */
-	protected $classAfter;
-
-	/**
-	 * @param string                      $fileAfter
-	 * @param \PhpParser\Node\Stmt\Class_ $classAfter
-	 */
-	public function __construct($fileAfter, Class_ $classAfter)
-	{
-		$this->fileAfter = $fileAfter;
-		$this->classAfter = $classAfter;
-	}
-
-	/**
-	 * @return string
-	 */
-	public function getLocation()
-	{
-		return $this->fileAfter;
-	}
-
-	/**
-	 * @return int
-	 */
-	public function getLine()
-	{
-		return $this->classAfter->getLine();
-	}
-
-	/**
-	 * @return string
-	 */
-	public function getTarget()
-	{
-		return PClass::getFullyQualifiedName($this->classAfter);
-	}
 }

src/PHPSemVerChecker/Operation/ClassMethodRemoved.php

@@ -2,10 +2,6 @@
 
 namespace PHPSemVerChecker\Operation;
 
-use PhpParser\Node\Stmt;
-use PhpParser\Node\Stmt\ClassMethod;
-use PHPSemVerChecker\Node\Statement\ClassMethod as PClassMethod;
-
 class ClassMethodRemoved extends ClassMethodOperationUnary {
 	/**
 	 * @var array

src/PHPSemVerChecker/Operation/ClassOperationUnary.php

@@ -0,0 +1,52 @@
+<?php
+
+namespace PHPSemVerChecker\Operation;
+
+use PhpParser\Node\Stmt\Class_;
+use PHPSemVerChecker\Node\Statement\Class_ as PClass;
+
+class ClassOperationUnary extends Operation
+{
+	/**
+	 * @var string
+	 */
+	protected $file;
+	/**
+	 * @var \PhpParser\Node\Stmt\Class_
+	 */
+	protected $class;
+
+	/**
+	 * @param string                      $file
+	 * @param \PhpParser\Node\Stmt\Class_ $class
+	 */
+	public function __construct($file, Class_ $class)
+	{
+		$this->file = $file;
+		$this->class = $class;
+	}
+
+	/**
+	 * @return string
+	 */
+	public function getLocation()
+	{
+		return $this->file;
+	}
+
+	/**
+	 * @return int
+	 */
+	public function getLine()
+	{
+		return $this->class->getLine();
+	}
+
+	/**
+	 * @return string
+	 */
+	public function getTarget()
+	{
+		return PClass::getFullyQualifiedName($this->class);
+	}
+}

src/PHPSemVerChecker/Operation/ClassRemoved.php

@@ -2,10 +2,7 @@
 
 namespace PHPSemVerChecker\Operation;
 
-use PhpParser\Node\Stmt\Class_;
-use PHPSemVerChecker\Node\Statement\Class_ as PClass;
-
-class ClassRemoved extends Operation {
+class ClassRemoved extends ClassOperationUnary {
 	/**
 	 * @var string
 	 */
@@ -14,46 +11,4 @@ class ClassRemoved extends Operation {
 	 * @var string
 	 */
 	protected $reason = 'Class was removed.';
-	/**
-	 * @var string
-	 */
-	protected $fileBefore;
-	/**
-	 * @var \PhpParser\Node\Stmt\Class_
-	 */
-	protected $classBefore;
-
-	/**
-	 * @param string                      $fileBefore
-	 * @param \PhpParser\Node\Stmt\Class_ $classBefore
-	 */
-	public function __construct($fileBefore, Class_ $classBefore)
-	{
-		$this->fileBefore = $fileBefore;
-		$this->classBefore = $classBefore;
-	}
-
-	/**
-	 * @return string
-	 */
-	public function getLocation()
-	{
-		return $this->fileBefore;
-	}
-
-	/**
-	 * @return int
-	 */
-	public function getLine()
-	{
-		return $this->classBefore->getLine();
-	}
-
-	/**
-	 * @return string
-	 */
-	public function getTarget()
-	{
-		return PClass::getFullyQualifiedName($this->classBefore);
-	}
 }

src/PHPSemVerChecker/Operation/FunctionImplementationChanged.php

@@ -2,9 +2,6 @@
 
 namespace PHPSemVerChecker\Operation;
 
-use PhpParser\Node\Stmt\Function_;
-use PHPSemVerChecker\Node\Statement\Function_ as PFunction;
-
 class FunctionImplementationChanged extends FunctionOperationDelta {
 	/**
 	 * @var string

src/PHPSemVerChecker/Operation/FunctionParameterRemoved.php

@@ -2,9 +2,6 @@
 
 namespace PHPSemVerChecker\Operation;
 
-use PhpParser\Node\Stmt\Function_;
-use PHPSemVerChecker\Node\Statement\Function_ as PFunction;
-
 class FunctionParameterRemoved extends FunctionOperationUnary
 {
 	/**

src/PHPSemVerChecker/Operation/InterfaceAdded.php

@@ -2,10 +2,7 @@
 
 namespace PHPSemVerChecker\Operation;
 
-use PhpParser\Node\Stmt\Interface_;
-use PHPSemVerChecker\Node\Statement\Interface_ as PInterface;
-
-class InterfaceAdded extends Operation {
+class InterfaceAdded extends InterfaceOperationUnary {
 	/**
 	 * @var string
 	 */
@@ -14,46 +11,4 @@ class InterfaceAdded extends Operation {
 	 * @var string
 	 */
 	protected $reason = 'Interface was added.';
-	/**
-	 * @var string
-	 */
-	protected $fileAfter;
-	/**
-	 * @var \PhpParser\Node\Stmt\Interface_
-	 */
-	protected $interfaceAfter;
-
-	/**
-	 * @param string                          $fileAfter
-	 * @param \PhpParser\Node\Stmt\Interface_ $interfaceAfter
-	 */
-	public function __construct($fileAfter, Interface_ $interfaceAfter)
-	{
-		$this->fileAfter = $fileAfter;
-		$this->interfaceAfter = $interfaceAfter;
-	}
-
-	/**
-	 * @return string
-	 */
-	public function getLocation()
-	{
-		return $this->fileAfter;
-	}
-
-	/**
-	 * @return int
-	 */
-	public function getLine()
-	{
-		return $this->interfaceAfter->getLine();
-	}
-
-	/**
-	 * @return string
-	 */
-	public function getTarget()
-	{
-		return PInterface::getFullyQualifiedName($this->interfaceAfter);
-	}
 }

src/PHPSemVerChecker/Operation/InterfaceOperationUnary.php

@@ -0,0 +1,51 @@
+<?php
+
+namespace PHPSemVerChecker\Operation;
+
+use PhpParser\Node\Stmt\Interface_;
+use PHPSemVerChecker\Node\Statement\Interface_ as PInterface;
+
+class InterfaceOperationUnary extends Operation {
+	/**
+	 * @var string
+	 */
+	protected $file;
+	/**
+	 * @var \PhpParser\Node\Stmt\Interface_
+	 */
+	protected $interface;
+
+	/**
+	 * @param string                          $fileAfter
+	 * @param \PhpParser\Node\Stmt\Interface_ $interface
+	 */
+	public function __construct($fileAfter, Interface_ $interface)
+	{
+		$this->file = $fileAfter;
+		$this->interface = $interface;
+	}
+
+	/**
+	 * @return string
+	 */
+	public function getLocation()
+	{
+		return $this->file;
+	}
+
+	/**
+	 * @return int
+	 */
+	public function getLine()
+	{
+		return $this->interface->getLine();
+	}
+
+	/**
+	 * @return string
+	 */
+	public function getTarget()
+	{
+		return PInterface::getFullyQualifiedName($this->interface);
+	}
+}

src/PHPSemVerChecker/Operation/InterfaceRemoved.php

@@ -2,10 +2,7 @@
 
 namespace PHPSemVerChecker\Operation;
 
-use PhpParser\Node\Stmt\Interface_;
-use PHPSemVerChecker\Node\Statement\Interface_ as PInterface;
-
-class InterfaceRemoved extends Operation {
+class InterfaceRemoved extends InterfaceOperationUnary {
 	/**
 	 * @var string
 	 */
@@ -14,46 +11,4 @@ class InterfaceRemoved extends Operation {
 	 * @var string
 	 */
 	protected $reason = 'Interface was removed.';
-	/**
-	 * @var string
-	 */
-	protected $fileBefore;
-	/**
-	 * @var \PhpParser\Node\Stmt\Interface_
-	 */
-	protected $interfaceBefore;
-
-	/**
-	 * @param string                          $fileBefore
-	 * @param \PhpParser\Node\Stmt\Interface_ $interfaceBefore
-	 */
-	public function __construct($fileBefore, Interface_ $interfaceBefore)
-	{
-		$this->fileBefore = $fileBefore;
-		$this->interfaceBefore = $interfaceBefore;
-	}
-
-	/**
-	 * @return string
-	 */
-	public function getLocation()
-	{
-		return $this->fileBefore;
-	}
-
-	/**
-	 * @return int
-	 */
-	public function getLine()
-	{
-		return $this->interfaceBefore->getLine();
-	}
-
-	/**
-	 * @return string
-	 */
-	public function getTarget()
-	{
-		return PInterface::getFullyQualifiedName($this->interfaceBefore);
-	}
 }