Skip to content

Commit 26109ab

Browse files
tomzxtomzx
committed
Revert SignatureTest.
1 parent 7bdf3e1 commit 26109ab

File tree

1 file changed

+46
-158
lines changed

1 file changed

+46
-158
lines changed

‎tests/PHPSemVerChecker/Comparator/SignatureTest.php‎

Lines changed: 46 additions & 158 deletions
Original file line numberDiff line numberDiff line change
@@ -2,187 +2,75 @@
22

33
namespace PHPSemVerChecker\Test\Comparator;
44

5-
use PhpParser\Node\Expr\ConstFetch;
6-
use PhpParser\Node\Name;
75
use PhpParser\Node\Param;
8-
use PhpParser\Node\Scalar\String_;
6+
use PhpParser\Node\Stmt\ClassMethod;
97
use PHPSemVerChecker\Comparator\Signature;
10-
use PHPSemVerChecker\Test\TestCase;
118

12-
class SignatureTest extends TestCase
9+
class SignatureTest extends \PHPUnit_Framework_TestCase
1310
{
14-
public function testAnalyzeNoParameter()
11+
public function testIdenticalSignaturesNoParameters()
1512
{
16-
$parametersA = [];
17-
$parametersB = [];
18-
$result = Signature::analyze($parametersA, $parametersB);
19-
$expected = Signature::changeArray();
20-
$this->assertSame($expected, $result);
21-
}
13+
$result = Signature::analyze([], []);
2214

23-
public function testAnalyzeParameterAdded()
24-
{
25-
$parametersA = [
26-
new Param('a', null, 'A'),
27-
];
28-
$parametersB = [
29-
new Param('a', null, 'A'),
30-
new Param('b', new String_('someDefaultValue'), 'B'),
15+
$expectedResult = [
16+
'parameter_added' => false,
17+
'parameter_removed' => false,
18+
'parameter_renamed' => false,
19+
'parameter_typing_added' => false,
20+
'parameter_typing_removed' => false,
21+
'parameter_default_added' => false,
22+
'parameter_default_removed' => false,
23+
'parameter_default_value_changed' => false,
3124
];
32-
$result = Signature::analyze($parametersA, $parametersB);
33-
$expected = Signature::changeArray();
34-
$expected['parameter_added'] = [
35-
0 => 1,
36-
];
37-
$this->assertSame($expected, $result);
38-
}
3925

40-
public function testAnalyzeParameterRemoved()
41-
{
42-
$parametersA = [
43-
new Param('a', null, 'A'),
44-
new Param('b', new String_('someDefaultValue'), 'B'),
45-
];
46-
$parametersB = [
47-
new Param('a', null, 'A'),
48-
];
49-
$result = Signature::analyze($parametersA, $parametersB);
50-
$expected = Signature::changeArray();
51-
$expected['parameter_removed'] = [
52-
0 => 1,
53-
];
54-
$this->assertSame($expected, $result);
26+
$this->assertEquals($expectedResult, $result);
5527
}
5628

57-
public function testAnalyzeParameterRenamed()
29+
public function testRenamedParameters()
5830
{
59-
$parametersA = [
60-
new Param('a', null, 'A'),
61-
new Param('b', new String_('someDefaultValue'), 'B'),
62-
];
63-
$parametersB = [
64-
new Param('c', null, 'A'),
65-
new Param('d', new String_('someDefaultValue'), 'B'),
66-
];
67-
$result = Signature::analyze($parametersA, $parametersB);
68-
$expected = Signature::changeArray();
69-
$expected['parameter_renamed'] = [
70-
0 => ['before' => 'a', 'after' => 'c'],
71-
1 => ['before' => 'b', 'after' => 'd'],
72-
];
73-
$this->assertSame($expected, $result);
74-
}
31+
$params1 = [new Param('testParameter')];
32+
$params2 = [new Param('testRenamedParameter')];
7533

76-
public function testAnalyzeParameterRenamedX()
77-
{
78-
$parametersA = [
79-
new Param('a', null, 'A'),
80-
new Param('b', new String_('someDefaultValue'), 'B'),
81-
];
82-
$parametersB = [
83-
new Param('b', new String_('someDefaultValue'), 'B'),
84-
new Param('a', null, 'A'),
85-
];
86-
$result = Signature::analyze($parametersA, $parametersB);
87-
$expected = Signature::changeArray();
88-
//$expected['parameter_renamed'] = [
89-
// 0 => ['before' => 'a', 'after' => 'c'],
90-
// 1 => ['before' => 'b', 'after' => 'd'],
91-
//];
92-
$this->assertSame($expected, $result);
93-
}
34+
$result = Signature::analyze($params1, $params2);
9435

95-
public function testAnalyzeParameterTypingAdded()
96-
{
97-
$parametersA = [
98-
new Param('a', null),
99-
];
100-
$parametersB = [
101-
new Param('a', null, 'A'),
102-
];
103-
$result = Signature::analyze($parametersA, $parametersB);
104-
$expected = Signature::changeArray();
105-
$expected['parameter_typing_added'] = [
106-
0 => ['A'],
36+
$expectedResult = [
37+
'parameter_added' => false,
38+
'parameter_removed' => false,
39+
'parameter_renamed' => true,
40+
'parameter_typing_added' => false,
41+
'parameter_typing_removed' => false,
42+
'parameter_default_added' => false,
43+
'parameter_default_removed' => false,
44+
'parameter_default_value_changed' => false,
10745
];
108-
$this->assertSame($expected, $result);
109-
}
11046

111-
public function testAnalyzeParameterTypingRemoved()
112-
{
113-
$parametersA = [
114-
new Param('a', null, 'A'),
115-
];
116-
$parametersB = [
117-
new Param('a', null),
118-
];
119-
$result = Signature::analyze($parametersA, $parametersB);
120-
$expected = Signature::changeArray();
121-
$expected['parameter_typing_removed'] = [
122-
0 => ['A'],
123-
];
124-
$this->assertSame($expected, $result);
47+
$this->assertEquals($expectedResult, $result);
12548
}
12649

127-
public function testAnalyzeParameterDefaultAdded()
50+
public function testAddedParameters()
12851
{
129-
$parametersA = [
130-
new Param('a'),
52+
$params1 = [
53+
new Param('testParameter'),
13154
];
132-
$parametersB = [
133-
new Param('a', new ConstFetch(new Name('null'))),
134-
];
135-
$result = Signature::analyze($parametersA, $parametersB);
136-
$expected = Signature::changeArray();
137-
$expected['parameter_default_added'] = [
138-
0 => [new ConstFetch(new Name('null'))],
139-
];
140-
$this->assertEquals($expected, $result);
141-
}
14255

143-
public function testAnalyzeParameterDefaultRemoved()
144-
{
145-
$parametersA = [
146-
new Param('a', new ConstFetch(new Name('null'))),
147-
];
148-
$parametersB = [
149-
new Param('a'),
56+
$params2 = [
57+
new Param('testParameter'),
58+
new Param('testAddedParameter'),
15059
];
151-
$result = Signature::analyze($parametersA, $parametersB);
152-
$expected = Signature::changeArray();
153-
$expected['parameter_default_removed'] = [
154-
0 => [new ConstFetch(new Name('null'))],
155-
];
156-
$this->assertEquals($expected, $result);
157-
}
15860

159-
public function testAnalyzeParameterDefaultValueChanged()
160-
{
161-
$parametersA = [
162-
new Param('a', new ConstFetch(new Name('null'))),
163-
];
164-
$parametersB = [
165-
new Param('a', new ConstFetch(new Name('true'))),
166-
];
167-
$result = Signature::analyze($parametersA, $parametersB);
168-
$expected = Signature::changeArray();
169-
$expected['parameter_default_value_changed'] = [
170-
0 => [new ConstFetch(new Name('null'))],
171-
];
172-
$this->assertEquals($expected, $result);
173-
}
61+
$result = Signature::analyze($params1, $params2);
17462

175-
public function testAnalyzeParameterAddedWithDefault()
176-
{
177-
$parametersA = [];
178-
$parametersB = [
179-
new Param('b', new String_('someDefaultValue'), 'B'),
63+
$expectedResult = [
64+
'parameter_added' => true,
65+
'parameter_removed' => false,
66+
'parameter_renamed' => false,
67+
'parameter_typing_added' => false,
68+
'parameter_typing_removed' => false,
69+
'parameter_default_added' => false,
70+
'parameter_default_removed' => false,
71+
'parameter_default_value_changed' => false,
18072
];
181-
$result = Signature::analyze($parametersA, $parametersB);
182-
$expected = Signature::changeArray();
183-
//$expected['parameter_default_value_changed'] = [
184-
// 0 => [new ConstFetch(new Name('null'))],
185-
//];
186-
$this->assertEquals($expected, $result);
73+
74+
$this->assertEquals($expectedResult, $result);
18775
}
18876
}

0 commit comments

Comments
 (0)