Add and use InputMerger

Author: nochso

src/PHPSemVerChecker/Console/Command/CompareCommand.php

@@ -5,6 +5,7 @@
 use PHPSemVerChecker\Analyzer\Analyzer;
 use PHPSemVerChecker\Configuration\Configuration;
 use PHPSemVerChecker\Configuration\LevelMapping;
+use PHPSemVerChecker\Console\InputMerger;
 use PHPSemVerChecker\Filter\SourceFilter;
 use PHPSemVerChecker\Finder\Finder;
 use PHPSemVerChecker\Reporter\JsonReporter;
@@ -40,8 +41,10 @@ protected function execute(InputInterface $input, OutputInterface $output)
 	{
 		$startTime = microtime(true);
 
-		$config = $input->getOption('config');
-		$configuration = $config ? Configuration::fromFile($config) : Configuration::defaults();
+		$configPath = $input->getOption('config');
+		$configuration = $configPath ? Configuration::fromFile($configPath) : Configuration::defaults();
+		$im = new InputMerger();
+		$im->merge($input, $configuration);
 
 		// Set overrides
 		LevelMapping::setOverrides($configuration->getLevelMapping());

src/PHPSemVerChecker/Console/InputMerger.php

@@ -0,0 +1,41 @@
+<?php
+
+namespace PHPSemVerChecker\Console;
+
+use PHPSemVerChecker\Configuration\Configuration;
+use Symfony\Component\Console\Input\InputInterface;
+
+/**
+ * Merges CLI input with existing configuration values.
+ *
+ * This is to ensure that CLI input has priority and is prepared for validation
+ * by symfony/console commands.
+ */
+class InputMerger
+{
+	/**
+	 * @param \Symfony\Component\Console\Input\InputInterface $input
+	 * @param \PHPSemVerChecker\Configuration\Configuration $config
+	 */
+	public function merge(InputInterface $input, Configuration $config)
+	{
+		$missingArguments = $this->getKeysOfNullValues($input->getArguments());
+		foreach ($missingArguments as $key) {
+			$input->setArgument($key, $config->get($key));
+		}
+		$missingOptions = $this->getKeysOfNullValues($input->getOptions());
+		foreach ($missingOptions as $key) {
+			$input->setOption($key, $config->get($key));
+		}
+		$config->merge(array_merge($input->getArguments(), $input->getOptions()));
+	}
+
+	/**
+	 * @param array $array
+	 * @return array
+	 */
+	private function getKeysOfNullValues(array $array)
+	{
+		return array_keys(array_filter($array, 'is_null'));
+	}
+}