Skip to content

Commit c53cde2

Browse files
committed
Changed the way how showing/hiding works.
1 parent 9ca21ea commit c53cde2

File tree

5 files changed

+36
-27
lines changed

5 files changed

+36
-27
lines changed

css/style.css

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@
33
display: flex;
44
}
55

6+
.gitlab-tree-plugin-hidden
7+
{
8+
display: none;
9+
}
10+
611
.gitlab-tree-plugin-left
712
{
813
flex: 0 0 250px;

manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "GitLab - Tree view for code",
33
"homepage_url": "https://github.com/tomasbonco/gitlabtree",
44
"author": "Tomáš Bončo",
5-
"version": "0.0.3",
5+
"version": "0.0.4",
66
"manifest_version": 2,
77
"description": "Provides folder structure view for code in GitLab.",
88
"icons": {

src/inject/inject.js

Lines changed: 12 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/inject/inject.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/inject/inject.ts

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,11 @@ class GitLabTree
55
fileNames: string[];
66
strippedFileNames: string[];
77

8-
wrapperElement: HTMLDivElement;
9-
leftElement: HTMLDivElement;
10-
rightElement: HTMLDivElement;
8+
wrapperElement: HTMLDivElement = document.createElement( 'div' );
9+
leftElement: HTMLDivElement = document.createElement( 'div' );
10+
rightElement: HTMLDivElement = document.createElement( 'div' );
11+
12+
lastActive: number = -1;
1113

1214
hashChangeListener: () => void;
1315

@@ -74,19 +76,10 @@ class GitLabTree
7476

7577

7678
/**
77-
* Resets all variables, creates required DOM elements.
79+
* Creates required DOM elements.
7880
*/
7981
init(): void
8082
{
81-
this.pathPrefix = '';
82-
this.fileHolders;
83-
this.fileNames = [];
84-
this.strippedFileNames = [];
85-
86-
this.wrapperElement = document.createElement( 'div' );
87-
this.leftElement = document.createElement( 'div' );
88-
this.rightElement = document.createElement( 'div' );
89-
9083
this.wrapperElement.appendChild( this.leftElement );
9184
this.wrapperElement.appendChild( this.rightElement );
9285

@@ -114,6 +107,9 @@ class GitLabTree
114107

115108
fileNames.push( fileName );
116109
files.removeChild( fileHolder );
110+
this.rightElement.appendChild( fileHolder );
111+
112+
fileHolder.classList.add( 'gitlab-tree-plugin-hidden' );
117113
}
118114

119115
return fileNames;
@@ -327,8 +323,14 @@ class GitLabTree
327323
*/
328324
showFile( id: number ): void
329325
{
330-
this.rightElement.innerHTML = '';
331-
this.rightElement.appendChild( this.fileHolders[ id ] );
326+
if ( this.lastActive !== -1 )
327+
{
328+
( this.fileHolders[ this.lastActive ] as HTMLElement ).classList.add( 'gitlab-tree-plugin-hidden' );
329+
}
330+
331+
( this.fileHolders[ id ] as HTMLElement ).classList.remove( 'gitlab-tree-plugin-hidden' );
332+
333+
this.lastActive = id;
332334
}
333335
}
334336

0 commit comments

Comments
 (0)