Rendering variables in injection URL #208

Author: tomasbjerre

CHANGELOG.md

@@ -2,6 +2,17 @@
 
 Changelog of Pull Request Notifier for Bitbucket.
 
+## Unreleased
+### GitHub [#208](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/issues/208) Injection URL does not allow variables
+  Rendering variables in injection URL
+  
+  [2fb4a6760970dd9](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/commit/2fb4a6760970dd9) Tomas Bjerre *2017-03-25 07:45:57*
+
+### No issue
+  Refering to violation comments to bbs for job DSL
+  
+  [85aabe1de07d124](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/commit/85aabe1de07d124) Tomas Bjerre *2017-03-18 12:59:43*
+
 ## 2.60
 ### GitHub [#197](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/issues/197) Button not displaying on PRs which are merged
   Adding previously uncommitted change for

src/main/java/se/bjurr/prnfb/service/PrnfbVariable.java

@@ -43,6 +43,7 @@
 import se.bjurr.prnfb.http.Invoker;
 import se.bjurr.prnfb.http.UrlInvoker;
 import se.bjurr.prnfb.listener.PrnfbPullRequestAction;
+import se.bjurr.prnfb.service.PrnfbRenderer.ENCODE_FOR;
 import se.bjurr.prnfb.settings.PrnfbNotification;
 
 public enum PrnfbVariable {
@@ -105,9 +106,25 @@ public String resolve(
           if (prnfbNotification == null || !prnfbNotification.getInjectionUrl().isPresent()) {
             return "";
           }
+          PrnfbRenderer renderer =
+              new PrnfbRenderer(
+                  pullRequest,
+                  pullRequestAction,
+                  applicationUser,
+                  repositoryService,
+                  propertiesService,
+                  prnfbNotification,
+                  variables,
+                  securityService);
+          String renderedUrlParam =
+              renderer.render(
+                  prnfbNotification.getInjectionUrl().get(),
+                  ENCODE_FOR.URL,
+                  clientKeyStore,
+                  shouldAcceptAnyCertificate);
           UrlInvoker urlInvoker =
               urlInvoker() //
-                  .withUrlParam(prnfbNotification.getInjectionUrl().get()) //
+                  .withUrlParam(renderedUrlParam) //
                   .withMethod(GET) //
                   .withProxyServer(prnfbNotification.getProxyServer()) //
                   .withProxyPort(prnfbNotification.getProxyPort()) //