Linting with JSHint

 * Found JS that may crashes in IE9. #116

Author: tomasbjerre

CHANGELOG.md

@@ -2,6 +2,12 @@
 
 Changelog of Pull Request Notifier for Bitbucket.
 
+## Unreleased
+### No issue
+  doc
+  
+  [6e92abeebfaae7b](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/commit/6e92abeebfaae7b) Tomas Bjerre *2016-05-11 15:36:41*
+
 ## 2.19
 ### No issue
   Using password type for keystore password field

Gruntfile.js

@@ -2,6 +2,16 @@ module.exports = function(grunt) {
  grunt.initConfig({
   pkg: grunt.file.readJSON('package.json'),
 
+  jshint: {
+   all: [
+    'src/main/resources/pr-triggerbutton.js',
+    'src/main/resources/admin.js',
+    'src/main/resources/utils.js'
+   ],
+   options: {
+    esversion: 3
+   }
+  },
 
   jsbeautifier: {
    files: ["Gruntfile.js",
@@ -29,6 +39,7 @@ module.exports = function(grunt) {
  });
 
  grunt.loadNpmTasks("grunt-jsbeautifier");
+ grunt.loadNpmTasks('grunt-contrib-jshint');
 
- grunt.registerTask('default', ['jsbeautifier']);
+ grunt.registerTask('default', ['jsbeautifier', 'jshint']);
 };

package.json

@@ -2,6 +2,7 @@
   "devDependencies": {
     "grunt": "0.4.5",
     "grunt-cli": "0.1.13",
+    "grunt-contrib-jshint": "^1.0.0",
     "grunt-jsbeautifier": "0.2.10"
   }
 }

src/main/resources/3rdparty.js

@@ -1,5 +1,5 @@
 define('plugin/prnfb/3rdparty', [
- 'jquery',
+ 'jquery'
 ], function($) {
 
  /**

src/main/resources/pr-triggerbutton.js

@@ -23,7 +23,7 @@ define('plugin/prnfb/pr-triggerbutton', [
  $buttonArea.append($buttonDropdownParent);
  $buttonDropdownParent.hide();
 
- $("body").append($buttonDropdownArea)
+ $("body").append($buttonDropdownArea);
 
  function loadSettingsAndShowButtons() {
   var hasButtons = false;

src/main/resources/utils.js

@@ -114,8 +114,8 @@ define('plugin/prnfb/utils', [
    }
   }
   var textareas = $within.find('textarea');
-  for (var i = 0; i < textareas.length; i++) {
-   if ($(textareas[i]).val()) {
+  for (var j = 0; j < textareas.length; j++) {
+   if ($(textareas[j]).val()) {
     return false;
    }
   }
@@ -139,7 +139,7 @@ define('plugin/prnfb/utils', [
    }
   }
 
-  if (empties.length == 0) {
+  if (empties.length === 0) {
    $empty = $listField.clone();
    $empty.find('input, textarea').val('');
    $listFieldsDiv.append($empty);
@@ -252,5 +252,5 @@ define('plugin/prnfb/utils', [
  return {
   setupForm: setupForm,
   setupForms: setupForms
- }
+ };
 });