Skip to content
This repository was archived by the owner on Jun 9, 2021. It is now read-only.

Commit 65de828

Browse files
committed
Only select checkboxes marked as default true in button forms #178
1 parent 5c4fa28 commit 65de828

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

CHANGELOG.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,16 @@
33
Changelog of Pull Request Notifier for Bitbucket.
44

55
## Unreleased
6+
### GitHub [#178](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/issues/178) Forms with checkboxes that have a default value of false do not work
7+
Only select checkboxes marked as default true in button forms
8+
9+
[c67aac2253b2fef](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/commit/c67aac2253b2fef) Tomas Bjerre *2017-01-03 17:32:10*
10+
11+
## 2.46
612
### GitHub [#178](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/issues/178) Forms with checkboxes that have a default value of false do not work
713
Using boolean for defaultValue in ButtonFormElementOption
814

9-
[edbe86ab15b83f0](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/commit/edbe86ab15b83f0) Tomas Bjerre *2017-01-03 08:06:27*
15+
[857b440e069912f](https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/commit/857b440e069912f) Tomas Bjerre *2017-01-03 08:09:39*
1016

1117
### No issue
1218
fixed jenkins plugin url

src/main/resources/pr-triggerbutton.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ define('plugin/prnfb/pr-triggerbutton', [
7878
var itemName = _.escape(nestedItem.name);
7979
var itemLabel = _.escape(nestedItem.label);
8080
return $('<div class="checkbox">' + //
81-
'<input class="checkbox" value="' + itemName + '" type="checkbox" checked=' + (isChecked ? '"checked"' : '""') + //
81+
'<input class="checkbox" value="' + itemName + '" type="checkbox" ' + (isChecked ? 'checked="checked"' : '') + //
8282
' name="' + outerName + '[]" id="prnfb-form-' + outerName + '-' + num + '">' + //
8383
'<label for="prnfb-form-' + outerName + '-' + num + '"' + //
8484
'>' + itemLabel + '</label></div>');

0 commit comments

Comments
 (0)