feat(snowflake)!: Added decfloat type #6444
Merged
+306
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geooo109
reviewed
Dec 1, 2025
geooo109
reviewed
Dec 1, 2025
geooo109
reviewed
Dec 1, 2025
fivetran-kwoodbeck
force-pushed
the
feature/decfloat
branch
from
decbfa2 to
2ab96c4
Compare
geooo109
reviewed
Dec 2, 2025
geooo109
reviewed
Dec 2, 2025
georgesittas
approved these changes
Dec 2, 2025
geooo109
approved these changes
Dec 2, 2025
fivetran-kwoodbeck
force-pushed
the
feature/decfloat
branch
from
065b2a5 to
1e30447
Compare
georgesittas
reviewed
Dec 2, 2025
Comment on lines
+283
to
+289
| expr_type: {"annotator": lambda self, e: self._annotate_by_args(e, "this")} | ||
| for expr_type in { | ||
| exp.Ceil, | ||
| exp.Floor, | ||
| exp.Round, | ||
| } | ||
| }, |
Collaborator
There was a problem hiding this comment.
I think there was an oversight here: we already have a similar dict explosion in L169, so these three should be moved back there / reverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the decfloat type for Snowflake.
Definition:
https://docs.snowflake.com/en/sql-reference/data-types-numeric#label-data-type-decfloat