validate identity for DECFLOAT and took out FLOAT tests

Author: fivetran-kwoodbeck

sqlglot/typing/snowflake.py

@@ -103,18 +103,17 @@ def _annotate_within_group(self: TypeAnnotator, expression: exp.WithinGroup) ->
 def _annotate_math_with_float_decfloat(
     self: TypeAnnotator, expression: exp.Expression
 ) -> exp.Expression:
-    """Annotate math functions that preserve FLOAT and DECFLOAT but return DOUBLE for integers.
+    """Annotate math functions that preserve  DECFLOAT but return DOUBLE for others.
 
     In Snowflake, trigonometric and exponential math functions:
-    - If input is FLOAT -> return FLOAT
     - If input is DECFLOAT -> return DECFLOAT
     - For integer types (INT, BIGINT, etc.) -> return DOUBLE
     - For other numeric types (NUMBER, DECIMAL, DOUBLE) -> return DOUBLE
     """
     expression = self._annotate_by_args(expression, "this")
 
-    # If input is FLOAT or DECFLOAT, preserve that type
-    if expression.this.is_type(exp.DataType.Type.FLOAT, exp.DataType.Type.DECFLOAT):
+    # If input is DECFLOAT, preserve
+    if expression.this.is_type(exp.DataType.Type.DECFLOAT):
         self._set_type(expression, expression.this.type)
     else:
         # For all other types (integers, decimals, etc.), return DOUBLE

tests/dialects/test_snowflake.py

@@ -180,6 +180,10 @@ def test_snowflake(self):
         self.validate_identity("SELECT TO_TIMESTAMP_LTZ(x) FROM t")
         self.validate_identity("SELECT TO_TIMESTAMP_TZ(x) FROM t")
         self.validate_identity("TO_DECIMAL(expr, fmt, precision, scale)")
+        self.validate_identity("TO_DECFLOAT('123.456')")
+        self.validate_identity("TO_DECFLOAT('1,234.56', '999,999.99')")
+        self.validate_identity("TRY_TO_DECFLOAT('123.456')")
+        self.validate_identity("TRY_TO_DECFLOAT('1,234.56', '999,999.99')")
         self.validate_identity("ALTER TABLE authors ADD CONSTRAINT c1 UNIQUE (id, email)")
         self.validate_identity("RM @parquet_stage", check_command_warning=True)
         self.validate_identity("REMOVE @parquet_stage", check_command_warning=True)

tests/fixtures/optimizer/annotate_functions.sql

@@ -3013,128 +3013,128 @@ SQRT(CAST(16 AS DECFLOAT));
 DECFLOAT;
 
 # dialect: snowflake
-SQRT(CAST(16 AS FLOAT));
-FLOAT;
+SQRT(CAST(16 AS DOUBLE));
+DOUBLE;
 
 # dialect: snowflake
 EXP(CAST(2 AS DECFLOAT));
 DECFLOAT;
 
 # dialect: snowflake
-EXP(CAST(2 AS FLOAT));
-FLOAT;
+EXP(CAST(2 AS DOUBLE));
+DOUBLE;
 
 # dialect: snowflake
 LN(CAST(10 AS DECFLOAT));
 DECFLOAT;
 
 # dialect: snowflake
-LN(CAST(10 AS FLOAT));
-FLOAT;
+LN(CAST(10 AS DOUBLE));
+DOUBLE;
 
 # dialect: snowflake
 LOG(CAST(100 AS DECFLOAT), 10);
 DECFLOAT;
 
 # dialect: snowflake
-LOG(CAST(100 AS FLOAT), 10);
-FLOAT;
+LOG(CAST(100 AS DOUBLE), 10);
+DOUBLE;
 
 # dialect: snowflake
 POW(CAST(2 AS DECFLOAT), 3);
 DECFLOAT;
 
 # dialect: snowflake
-POW(CAST(2 AS FLOAT), 3);
-FLOAT;
+POW(CAST(2 AS DOUBLE), 3);
+DOUBLE;
 
 # dialect: snowflake
 SIN(CAST(1.5 AS DECFLOAT));
 DECFLOAT;
 
 # dialect: snowflake
-SIN(CAST(1.5 AS FLOAT));
-FLOAT;
+SIN(CAST(1.5 AS DOUBLE));
+DOUBLE;
 
 # dialect: snowflake
 COS(CAST(1.5 AS DECFLOAT));
 DECFLOAT;
 
 # dialect: snowflake
-COS(CAST(1.5 AS FLOAT));
-FLOAT;
+COS(CAST(1.5 AS DOUBLE));
+DOUBLE;
 
 # dialect: snowflake
 TAN(CAST(1.5 AS DECFLOAT));
 DECFLOAT;
 
 # dialect: snowflake
-TAN(CAST(1.5 AS FLOAT));
-FLOAT;
+TAN(CAST(1.5 AS DOUBLE));
+DOUBLE;
 
 # dialect: snowflake
 COT(CAST(1.5 AS DECFLOAT));
 DECFLOAT;
 
 # dialect: snowflake
-COT(CAST(1.5 AS FLOAT));
-FLOAT;
+COT(CAST(1.5 AS DOUBLE));
+DOUBLE;
 
 # dialect: snowflake
 ASIN(CAST(0.5 AS DECFLOAT));
 DECFLOAT;
 
 # dialect: snowflake
-ASIN(CAST(0.5 AS FLOAT));
-FLOAT;
+ASIN(CAST(0.5 AS DOUBLE));
+DOUBLE;
 
 # dialect: snowflake
 ACOS(CAST(0.5 AS DECFLOAT));
 DECFLOAT;
 
 # dialect: snowflake
-ACOS(CAST(0.5 AS FLOAT));
-FLOAT;
+ACOS(CAST(0.5 AS DOUBLE));
+DOUBLE;
 
 # dialect: snowflake
 ATAN(CAST(1 AS DECFLOAT));
 DECFLOAT;
 
 # dialect: snowflake
-ATAN(CAST(1 AS FLOAT));
-FLOAT;
+ATAN(CAST(1 AS DOUBLE));
+DOUBLE;
 
 # dialect: snowflake
 ATAN2(CAST(1 AS DECFLOAT), 1);
 DECFLOAT;
 
 # dialect: snowflake
-ATAN2(CAST(1 AS FLOAT), 1);
-FLOAT;
+ATAN2(CAST(1 AS DOUBLE), 1);
+DOUBLE;
 
 # dialect: snowflake
 DEGREES(CAST(3.14159 AS DECFLOAT));
 DECFLOAT;
 
 # dialect: snowflake
-DEGREES(CAST(3.14159 AS FLOAT));
-FLOAT;
+DEGREES(CAST(3.14159 AS DOUBLE));
+DOUBLE;
 
 # dialect: snowflake
 RADIANS(CAST(180 AS DECFLOAT));
 DECFLOAT;
 
 # dialect: snowflake
-RADIANS(CAST(180 AS FLOAT));
-FLOAT;
+RADIANS(CAST(180 AS DOUBLE));
+DOUBLE;
 
 # dialect: snowflake
 TANH(CAST(1 AS DECFLOAT));
 DECFLOAT;
 
 # dialect: snowflake
-TANH(CAST(1 AS FLOAT));
-FLOAT;
+TANH(CAST(1 AS DOUBLE));
+DOUBLE;
 
 # dialect: snowflake
 TO_DECFLOAT('123.456');