#17 Coverage

Author: tobi-laa

src/main/kotlin/io/github/tobi/laa/spring/boot/embedded/redis/shardedcluster/RedisShardedClusterContextCustomizer.kt

@@ -102,7 +102,7 @@ internal class RedisShardedClusterContextCustomizer(
             .toList()
 
     private fun createClient(addresses: List<Pair<String, Int>>): JedisCluster {
-        return JedisCluster(addresses.map { HostAndPort(it.first, it.second) }.first())
+        return JedisCluster(addresses.map { HostAndPort(it.first, it.second) }.toSet())
     }
 
     private fun setSpringProperties(context: ConfigurableApplicationContext, addresses: List<Pair<String, Int>>) {

src/test/kotlin/io/github/tobi/laa/spring/boot/embedded/redis/RedisTests.kt

@@ -11,9 +11,16 @@ import org.springframework.context.ApplicationContextAware
 import org.springframework.context.annotation.Scope
 import org.springframework.data.redis.core.RedisTemplate
 import org.springframework.stereotype.Component
+import redis.embedded.RedisShardedCluster
+import java.time.Duration
 import java.util.*
 import kotlin.random.Random
 
+private val INITIALIZATION_TIMEOUT_PROP = RedisShardedCluster::class.java.declaredFields
+    .filter { it.name == "initializationTimeout" }
+    .map { field -> field.isAccessible = true; field }
+    .first()
+
 /**
  * Used for sharing common test logic across different test classes.
  */
@@ -148,6 +155,14 @@ internal open class RedisTests(
             val conf = RedisConfParser.parse(RedisConfLocator.locate(server))
             return RedisConfAssertion(conf)
         }
+
+        fun shouldHaveInitializationTimeout(timeout: Duration): EmbeddedRedis {
+            val server = context?.let { RedisStore.server(it) }!!
+            assertThat(server).isInstanceOf(RedisShardedCluster::class.java)
+            val configuredTimeout = INITIALIZATION_TIMEOUT_PROP[server as RedisShardedCluster]
+            assertThat(configuredTimeout).isEqualTo(timeout)
+            return this
+        }
     }
 
     inner class RedisConfAssertion(val conf: RedisConf) {

src/test/kotlin/io/github/tobi/laa/spring/boot/embedded/redis/server/ExecutionDirTest.kt

@@ -7,7 +7,7 @@ import org.junit.jupiter.api.Test
 import org.springframework.beans.factory.annotation.Autowired
 
 @IntegrationTest
-@EmbeddedRedisServer(executeInDirectory = "build", port = 10002)
+@EmbeddedRedisServer(executeInDirectory = "build")
 @DisplayName("Using @EmbeddedRedisServer with custom execution dir")
 internal class ExecutionDirTest {
 

src/test/kotlin/io/github/tobi/laa/spring/boot/embedded/redis/server/NoBindTest.kt

@@ -6,10 +6,8 @@ import org.junit.jupiter.api.DisplayName
 import org.junit.jupiter.api.Test
 import org.springframework.beans.factory.annotation.Autowired
 
-private const val TEST_PORT = 10003
-
 @IntegrationTest
-@EmbeddedRedisServer(bind = "", port = TEST_PORT)
+@EmbeddedRedisServer(bind = "")
 @DisplayName("Using @EmbeddedRedisServer with empty bind")
 internal class NoBindTest {
 

src/test/kotlin/io/github/tobi/laa/spring/boot/embedded/redis/server/RedisConfFileTest.kt

@@ -6,11 +6,9 @@ import org.junit.jupiter.api.DisplayName
 import org.junit.jupiter.api.Test
 import org.springframework.beans.factory.annotation.Autowired
 
-private const val TEST_PORT = 10004
 
 @IntegrationTest
 @EmbeddedRedisServer(
-    port = TEST_PORT,
     configFile = "src/test/resources/server/redis.conf"
 )
 @DisplayName("Using @EmbeddedRedisServer with config file")
@@ -26,8 +24,7 @@ internal class RedisConfFileTest {
             .whenDoingNothing()
             .then().redisProperties()
             .shouldBeStandalone().and()
-            .shouldHaveHost("localhost").and()
-            .shouldHavePort(TEST_PORT)
+            .shouldHaveHost("localhost")
     }
 
     @Test

src/test/kotlin/io/github/tobi/laa/spring/boot/embedded/redis/server/RedisServerContextCustomizerTest.kt

@@ -14,7 +14,7 @@ import redis.embedded.Redis
 @DisplayName("Tests for RedisServerContextCustomizer")
 internal class RedisServerContextCustomizerTest {
 
-    val givenCustomizer = RedisServerContextCustomizer(mockk<EmbeddedRedisServer>(), mockk<PortProvider>())
+    private val givenCustomizer = RedisServerContextCustomizer(mockk<EmbeddedRedisServer>(), mockk<PortProvider>())
 
     @Test
     @DisplayName("RedisServerContextCustomizer.equals() should be true for itself")
@@ -44,7 +44,7 @@ internal class RedisServerContextCustomizerTest {
         var client: UnifiedJedis? = null
         AnnotationConfigApplicationContext().use {
             RedisServerContextCustomizerFactory()
-                .createContextCustomizer(AnnotatedClass::class.java, mutableListOf())!!
+                .createContextCustomizer(AnnotatedClass::class.java, mutableListOf())
                 .customizeContext(it, mockk())
             it.refresh()
             it.start()

src/test/kotlin/io/github/tobi/laa/spring/boot/embedded/redis/shardedcluster/CustomSettingsTest.kt

@@ -0,0 +1,52 @@
+package io.github.tobi.laa.spring.boot.embedded.redis.shardedcluster
+
+import io.github.tobi.laa.spring.boot.embedded.redis.IntegrationTest
+import io.github.tobi.laa.spring.boot.embedded.redis.RedisTests
+import io.github.tobi.laa.spring.boot.embedded.redis.shardedcluster.EmbeddedRedisShardedCluster.Shard
+import org.junit.jupiter.api.DisplayName
+import org.junit.jupiter.api.Test
+import org.springframework.beans.factory.annotation.Autowired
+import java.time.Duration.ofSeconds
+
+@IntegrationTest
+@EmbeddedRedisShardedCluster(
+    shards = [
+        Shard(replicas = 1),
+        Shard(replicas = 2),
+        Shard(replicas = 3)],
+    ports = [6380, 7000, 7001, 7002, 7003, 7004, 7005, 11111, 22222]
+)
+@DisplayName("Using @EmbeddedRedisShardedCluster with custom settings")
+internal class CustomSettingsTest {
+
+    @Autowired
+    private lateinit var given: RedisTests
+
+    @Test
+    @DisplayName("RedisProperties should have the customized values")
+    fun redisPropertiesShouldHaveCustomizedValues() {
+        given.nothing()
+            .whenDoingNothing()
+            .then().redisProperties()
+            .shouldBeCluster()
+            .shouldHaveNode("127.0.0.1", 6380)
+            .shouldHaveNode("127.0.0.1", 7000)
+            .shouldHaveNode("127.0.0.1", 7001)
+            .shouldHaveNode("127.0.0.1", 7002)
+            .shouldHaveNode("127.0.0.1", 7003)
+            .shouldHaveNode("127.0.0.1", 7004)
+            .shouldHaveNode("127.0.0.1", 7005)
+            .shouldHaveNode("127.0.0.1", 11111)
+            .shouldHaveNode("127.0.0.1", 22222)
+            .andAlso().embeddedRedis()
+            .shouldHaveInitializationTimeout(ofSeconds(20))
+    }
+
+    @Test
+    @DisplayName("It should be possible to write to Redis and the data should be available afterwards")
+    fun givenRandomTestdata_writingToRedis_dataShouldBeAvailable() {
+        given.randomTestdata()
+            .whenRedis().isBeingWrittenTo()
+            .then().redis().shouldContainTheTestdata()
+    }
+}

src/test/kotlin/io/github/tobi/laa/spring/boot/embedded/redis/shardedcluster/ExecutionDirTest.kt

@@ -0,0 +1,24 @@
+package io.github.tobi.laa.spring.boot.embedded.redis.shardedcluster
+
+import io.github.tobi.laa.spring.boot.embedded.redis.IntegrationTest
+import io.github.tobi.laa.spring.boot.embedded.redis.RedisTests
+import org.junit.jupiter.api.DisplayName
+import org.junit.jupiter.api.Test
+import org.springframework.beans.factory.annotation.Autowired
+
+@IntegrationTest
+@EmbeddedRedisShardedCluster(executeInDirectory = "build")
+@DisplayName("Using @EmbeddedRedisShardedCluster with custom execution dir")
+internal class ExecutionDirTest {
+
+    @Autowired
+    private lateinit var given: RedisTests
+
+    @Test
+    @DisplayName("It should be possible to write to Redis and the data should be available afterwards")
+    fun givenRandomTestdata_writingToRedis_dataShouldBeAvailable() {
+        given.randomTestdata()
+            .whenRedis().isBeingWrittenTo()
+            .then().redis().shouldContainTheTestdata()
+    }
+}

src/test/kotlin/io/github/tobi/laa/spring/boot/embedded/redis/shardedcluster/RedisShardedClusterContextCustomizerTest.kt

@@ -0,0 +1,61 @@
+package io.github.tobi.laa.spring.boot.embedded.redis.shardedcluster
+
+import io.github.tobi.laa.spring.boot.embedded.redis.RedisStore
+import io.github.tobi.laa.spring.boot.embedded.redis.ports.PortProvider
+import io.mockk.mockk
+import org.assertj.core.api.Assertions.assertThat
+import org.assertj.core.api.Assertions.assertThatThrownBy
+import org.junit.jupiter.api.DisplayName
+import org.junit.jupiter.api.Test
+import org.springframework.context.annotation.AnnotationConfigApplicationContext
+import redis.clients.jedis.UnifiedJedis
+import redis.embedded.Redis
+
+@DisplayName("Tests for RedisShardedClusterContextCustomizer")
+internal class RedisShardedClusterContextCustomizerTest {
+
+    private val givenCustomizer =
+        RedisShardedClusterContextCustomizer(mockk<EmbeddedRedisShardedCluster>(), mockk<PortProvider>())
+
+    @Test
+    @DisplayName("RedisShardedClusterContextCustomizer.equals() should be true for itself")
+    fun sameObject_equals_shouldBeTrue() {
+        val comparedToSelf = givenCustomizer.equals(givenCustomizer)
+        assertThat(comparedToSelf).isTrue()
+    }
+
+    @Test
+    @DisplayName("RedisShardedClusterContextCustomizer.equals() should be false for null objects")
+    fun null_equals_shouldBeFalse() {
+        val comparedToDifferentClass = givenCustomizer.equals(null)
+        assertThat(comparedToDifferentClass).isFalse()
+    }
+
+    @Test
+    @DisplayName("RedisShardedClusterContextCustomizer.equals() should be false for object with different class")
+    fun differentClass_equals_shouldBeFalse() {
+        val comparedToDifferentClass = givenCustomizer.equals("I'm not a RedisServerContextCustomizer")
+        assertThat(comparedToDifferentClass).isFalse()
+    }
+
+    @Test
+    @DisplayName("Closing ApplicationContext should stop Redis server and Redis client")
+    fun closingApplicationContext_shouldStopRedisServerAndRedisClient() {
+        var server: Redis? = null
+        var client: UnifiedJedis? = null
+        AnnotationConfigApplicationContext().use {
+            RedisShardedClusterContextCustomizerFactory()
+                .createContextCustomizer(AnnotatedClass::class.java, mutableListOf())
+                .customizeContext(it, mockk())
+            it.refresh()
+            it.start()
+            server = RedisStore.server(it)
+            client = RedisStore.client(it)
+        }
+        assertThat(server!!.isActive).isFalse()
+        assertThatThrownBy { client!!.get("FOO") }.isInstanceOf(Exception::class.java)
+    }
+
+    @EmbeddedRedisShardedCluster
+    private class AnnotatedClass
+}