add test_has_lt_version and test_has_gt_version

Author: tony

doc/api.rst

@@ -69,8 +69,12 @@ Internals
 
 .. automethod:: libtmux.common.has_gt_version
 
+.. automethod:: libtmux.common.has_gte_version
+
 .. automethod:: libtmux.common.has_lt_version
 
+.. automethod:: libtmux.common.has_lte_version
+
 .. automethod:: libtmux.common.has_minimum_tmux_version
 
 .. automethod:: libtmux.common.handle_option_error

libtmux/common.py

@@ -441,9 +441,31 @@ def has_gt_version(min_version):
     :returns: True if version above min_version
     :rtype: bool
     """
+    return get_version() > LooseVersion(min_version)
+
+
+def has_gte_version(min_version):
+    """Return True if tmux version greater or equal to minimum.
+
+    :param min_version: version, e.g. '1.8'
+    :type min_version: string
+    :returns: True if version above or equal to min_version
+    :rtype: bool
+    """
     return get_version() >= LooseVersion(min_version)
 
 
+def has_lte_version(max_version):
+    """Return True if tmux version less or equal to minimum.
+
+    :param max_version: version, e.g. '1.8'
+    :type max_version: string
+    :returns: True if version below or equal to max_version
+    :rtype: bool
+    """
+    return get_version() <= LooseVersion(max_version)
+
+
 def has_lt_version(max_version):
     """Return True if tmux version less than minimum.
 
@@ -452,7 +474,7 @@ def has_lt_version(max_version):
     :returns: True if version below max_version
     :rtype: bool
     """
-    return get_version() <= LooseVersion(max_version)
+    return get_version() < LooseVersion(max_version)
 
 
 def has_minimum_tmux_version(raises=True):

tests/test_common.py

@@ -12,7 +12,8 @@
 
 from libtmux.common import (
     has_minimum_tmux_version, which, session_check_name, tmux_cmd,
-    has_version, has_gt_version, has_lt_version, get_version
+    has_version, has_gt_version, has_lt_version, get_version,
+    has_gte_version, has_lte_version
 )
 from libtmux.exc import LibTmuxException, BadSessionName, TmuxCommandNotFound
 
@@ -94,14 +95,35 @@ def test_has_version():
 def test_has_gt_version():
     assert has_gt_version('1.6')
     assert has_gt_version('1.6b')
+
     assert not has_gt_version('4.0')
+    assert not has_gt_version('4.0b')
+
+
+def test_has_gte_version():
+    assert has_gte_version('1.6')
+    assert has_gte_version('1.6b')
+    assert has_gte_version(str(get_version()))
+
+    assert not has_gte_version('4.0')
+    assert not has_gte_version('4.0b')
 
 
 def test_has_lt_version():
     assert has_lt_version('4.0a')
     assert has_lt_version('4.0')
 
     assert not has_lt_version('1.7')
+    assert not has_lt_version(str(get_version()))
+
+
+def test_has_lte_version():
+    assert has_lte_version('4.0a')
+    assert has_lte_version('4.0')
+    assert has_lte_version(str(get_version()))
+
+    assert not has_lte_version('1.7')
+    assert not has_lte_version('1.7b')
 
 
 def test_which_no_bin_found():