fixup! feat(Session.new_window): set up environment

Author: zappolowski

src/libtmux/session.py

@@ -19,6 +19,7 @@
     TmuxRelationalObject,
     WindowDict,
     handle_option_error,
+    has_gte_version,
     has_version,
     session_check_name,
 )
@@ -261,8 +262,13 @@ def new_window(
         )
 
         if environment:
-            for k, v in environment.items():
-                window_args += ("-e%s=%s" % (k, v),)
+            if has_gte_version("3.0"):
+                for k, v in environment.items():
+                    window_args += ("-e%s=%s" % (k, v),)
+            else:
+                logger.warning(
+                    "Cannot set up environment as tmux 3.0 or newer is required."
+                )
 
         if window_shell:
             window_args += (window_shell,)

tests/test_session.py

@@ -6,7 +6,7 @@
 import pytest
 
 from libtmux import exc
-from libtmux.common import has_gte_version
+from libtmux.common import has_gte_version, has_lt_version
 from libtmux.pane import Pane
 from libtmux.server import Server
 from libtmux.session import Session
@@ -260,6 +260,10 @@ def test_cmd_inserts_sesion_id(session: Session) -> None:
     assert cmd.cmd[-1] == last_arg
 
 
+@pytest.mark.skipif(
+    has_lt_version("3.0"),
+    reason="needs -e flag for new-window which was introduced in 3.0",
+)
 def test_new_window_with_environment(session: Session) -> None:
     env = shutil.which("env")
     assert env is not None, "Cannot find usable `env` in PATH."
@@ -274,3 +278,26 @@ def test_new_window_with_environment(session: Session) -> None:
     assert pane is not None
     pane.send_keys("echo $ENV_VAR")
     assert pane.capture_pane() == ["$ echo $ENV_VAR", "window", "$"]
+
+
+@pytest.mark.skipif(
+    has_gte_version("3.0"),
+    reason="3.0 has the -e flag on new-window",
+)
+def test_new_window_with_environment_logs_warning_for_old_tmux(
+    session: Session,
+    caplog: pytest.LogCaptureFixture,
+) -> None:
+    env = shutil.which("env")
+    assert env is not None, "Cannot find usable `env` in PATH."
+
+    session.new_window(
+        attach=True,
+        window_name="window_with_environment",
+        window_shell=f"{env} PS1='$ ' bash --norc --noprofile",
+        environment={"ENV_VAR": "window"},
+    )
+
+    assert any(
+        "Cannot set up environment" in record.msg for record in caplog.records
+    ), "Warning missing"