coverage for which function, use .info log fixes #12

Author: tony

libtmux/common.py

@@ -328,13 +328,18 @@ def get_by_id(self, id):
         return None
 
 
-def which(exe=None):
+def which(exe=None,
+          default_paths=[
+              '/bin', '/sbin', '/usr/bin', '/usr/sbin', '/usr/local/bin']
+          ):
     """Return path of bin. Python clone of /usr/bin/which.
 
     from salt.util - https://www.github.com/saltstack/salt - license apache
 
     :param exe: Application to search PATHs for.
     :type exe: string
+    :param default_path: Application to search PATHs for.
+    :type default_path: list
     :rtype: string
 
     """
@@ -352,17 +357,15 @@ def _is_executable_file_or_link(exe):
     # win' for cases to find optional alternatives
     search_path = os.environ.get('PATH') and \
         os.environ['PATH'].split(os.pathsep) or list()
-    for default_path in [
-        '/bin', '/sbin', '/usr/bin', '/usr/sbin', '/usr/local/bin'
-    ]:
+    for default_path in default_paths:
         if default_path not in search_path:
             search_path.append(default_path)
     os.environ['PATH'] = os.pathsep.join(search_path)
     for path in search_path:
         full_path = os.path.join(path, exe)
         if _is_executable_file_or_link(full_path):
             return full_path
-    logger.trace(
+    logger.info(
         '\'{0}\' could not be found in the following search path: '
         '\'{1}\''.format(exe, search_path))
 

tests/test_common.py

@@ -5,7 +5,7 @@
 
 import pytest
 
-from libtmux.common import has_required_tmux_version
+from libtmux.common import has_required_tmux_version, which
 from libtmux.exc import LibTmuxException
 
 version_regex = re.compile(r'[0-9]\.[0-9]')
@@ -44,3 +44,9 @@ def test_error_version_less_1_7():
         excinfo.match(r'tmuxp only supports')
 
     has_required_tmux_version('1.9a')
+
+
+def test_which_no_tmuxp_found(monkeypatch):
+    monkeypatch.setenv("PATH", "/")
+    which('tmuxp')
+    which('tmuxp', '/')