Remove negative number check from float sqrt

ollie27 · ollie27 · commit a35b4234df98 · 2020-01-04T23:44:19.000Z
It hasn't been UB to pass negative numbers to sqrt since https://reviews.llvm.org/D28797 which was included in LLVM 5.
diff --git a/src/libstd/f32.rs b/src/libstd/f32.rs
@@ -376,7 +376,7 @@ impl f32 {
     #[stable(feature = "rust1", since = "1.0.0")]
     #[inline]
     pub fn sqrt(self) -> f32 {
-        if self < 0.0 { NAN } else { unsafe { intrinsics::sqrtf32(self) } }
+        unsafe { intrinsics::sqrtf32(self) }
     }
 
     /// Returns `e^(self)`, (the exponential function).
diff --git a/src/libstd/f64.rs b/src/libstd/f64.rs
@@ -342,7 +342,7 @@ impl f64 {
     #[stable(feature = "rust1", since = "1.0.0")]
     #[inline]
     pub fn sqrt(self) -> f64 {
-        if self < 0.0 { NAN } else { unsafe { intrinsics::sqrtf64(self) } }
+        unsafe { intrinsics::sqrtf64(self) }
     }
 
     /// Returns `e^(self)`, (the exponential function).

Original file line number	Diff line number	Diff line change
`@@ -376,7 +376,7 @@ impl f32 {`
`376`	`376`	`#[stable(feature = "rust1", since = "1.0.0")]`
`377`	`377`	`#[inline]`
`378`	`378`	`pub fn sqrt(self) -> f32 {`
`379`		`- if self < 0.0 { NAN } else { unsafe { intrinsics::sqrtf32(self) } }`
	`379`	`+ unsafe { intrinsics::sqrtf32(self) }`
`380`	`380`	`}`
`381`	`381`
`382`	`382`	/// Returns `e^(self)`, (the exponential function).
Original file line number	Diff line number	Diff line change
`@@ -342,7 +342,7 @@ impl f64 {`
`342`	`342`	`#[stable(feature = "rust1", since = "1.0.0")]`
`343`	`343`	`#[inline]`
`344`	`344`	`pub fn sqrt(self) -> f64 {`
`345`		`- if self < 0.0 { NAN } else { unsafe { intrinsics::sqrtf64(self) } }`
	`345`	`+ unsafe { intrinsics::sqrtf64(self) }`
`346`	`346`	`}`
`347`	`347`
`348`	`348`	/// Returns `e^(self)`, (the exponential function).