Skip to content

Commit 95aa83f

Browse files
committed
add some test coverage to ecdsa.keys
1 parent 3bda7d7 commit 95aa83f

File tree

1 file changed

+18
-4
lines changed

1 file changed

+18
-4
lines changed

src/ecdsa/test_keys.py

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,8 @@ def setUpClass(cls):
150150
)
151151
cls.vk2 = VerifyingKey.from_pem(key_str)
152152

153+
cls.sk2 = SigningKey.generate(vk.curve)
154+
153155
def test_custom_hashfunc(self):
154156
vk = VerifyingKey.from_der(self.key_bytes, hashlib.sha256)
155157

@@ -196,10 +198,20 @@ def test_equality_on_verifying_keys(self):
196198
self.assertEqual(self.vk, self.sk.get_verifying_key())
197199

198200
def test_inequality_on_verifying_keys(self):
199-
self.assertNotEqual(self.vk, self.vk2)
201+
# use `==` to workaround instrumental <-> unittest compat issue
202+
self.assertFalse(self.vk == self.vk2)
200203

201204
def test_inequality_on_verifying_keys_not_implemented(self):
202-
self.assertNotEqual(self.vk, None)
205+
# use `==` to workaround instrumental <-> unittest compat issue
206+
self.assertFalse(self.vk == None)
207+
208+
def test_VerifyingKey_inequality_on_same_curve(self):
209+
# use `==` to workaround instrumental <-> unittest compat issue
210+
self.assertFalse(self.vk == self.sk2.verifying_key)
211+
212+
def test_SigningKey_inequality_on_same_curve(self):
213+
# use `==` to workaround instrumental <-> unittest compat issue
214+
self.assertFalse(self.sk == self.sk2)
203215

204216

205217
class TestSigningKey(unittest.TestCase):
@@ -271,10 +283,12 @@ def test_verify_with_lazy_precompute(self):
271283
self.assertTrue(vk.verify(sig, b"other message"))
272284

273285
def test_inequality_on_signing_keys(self):
274-
self.assertNotEqual(self.sk1, self.sk2)
286+
# use `==` to workaround instrumental <-> unittest compat issue
287+
self.assertFalse(self.sk1 == self.sk2)
275288

276289
def test_inequality_on_signing_keys_not_implemented(self):
277-
self.assertNotEqual(self.sk1, None)
290+
# use `==` to workaround instrumental <-> unittest compat issue
291+
self.assertFalse(self.sk1 == None)
278292

279293

280294
# test VerifyingKey.verify()

0 commit comments

Comments
 (0)