Create and Use InformationLeakTest.getRareResponses (#371) #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move getRareResponses method from SessionTicketPaddingOracleProbe to InformationLeakTest as non-static method - Update SessionTicketPaddingOracleProbe to use the new method location - Update TicketPaddingOracleResult to use the new method location - Add comprehensive unit tests for getRareResponses method - Fix implementation to correctly count total occurrences across all vectors This change makes the method reusable for other probes that need to identify rare response patterns, improving code organization and reusability. Fixes #371
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
getRareResponsesmethod fromSessionTicketPaddingOracleProbetoInformationLeakTestas a non-static methodDetails
This PR addresses issue #371 by refactoring the
getRareResponsesmethod to make it reusable across different probes. The method identifies response patterns that occur rarely (at most N times) across all test vectors, which is useful for various padding oracle and timing attack analyses.Changes made:
InformationLeakTest, allowing it to access the test's vector containers directlySessionTicketPaddingOracleProbeandTicketPaddingOracleResultnow use the new method locationTest plan
getRareResponsesmethod