Fix #110: Implement certificate chain validation for trusted field #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses issue #110 by implementing certificate chain validation to properly set the 'trusted' field in CertificateReport. Changes: - Added CertificateChainValidator class to validate certificate chains against trust anchors - Modified CertificateReportGenerator to use the validator when a full chain is available - Added overloaded generateReport method that accepts the full certificate chain - The 'trusted' field is now set based on whether the certificate chain validates to a trusted root The implementation checks if any certificate in the chain is a trust anchor or if the chain terminates at a trust anchor. This provides a basic but functional validation that resolves the issue where the 'trusted' field was always null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements certificate chain validation to properly set the
trustedfield inCertificateReport, which was previously alwaysnullas reported in issue #110.Changes
CertificateChainValidatorclass that validates certificate chains against loaded trust anchorsCertificateReportGeneratorto:trustedfield based on validation resultsImplementation Details
The validator checks if:
This provides a basic but functional validation that addresses the issue. The implementation reuses the existing
TrustAnchorManagerinfrastructure without requiring complex certificate path validation.Test Plan
Fixes #110