[AI] Fix issue #182: Prevent -version flag from overriding finishWithCloseNotify in DTLS #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Notify in DTLS When using the -version parameter with DTLS protocols, the ProtocolVersionDelegate was unconditionally setting finishWithCloseNotify to true, overriding any value that may have been set via XML configuration files. This fix removes the automatic override, allowing users to control the finishWithCloseNotify setting through their XML configuration files while still using the -version parameter for DTLS protocols. Changes: - Removed config.setFinishWithCloseNotify(true) from DTLS configuration in ProtocolVersionDelegate - Added tests to verify finishWithCloseNotify values are preserved for DTLS versions - Tests confirm both default (false) and explicitly set values are maintained
ic0ns
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
-versionparameter with DTLS protocols was overriding thefinishWithCloseNotifyconfiguration valuefinishWithCloseNotifyto true for DTLS protocols-versionparameterChanges
ProtocolVersionDelegate.applyDelegate()to not overridefinishWithCloseNotifywhen DTLS is specifiedTest plan
Context
This fixes issue #182 where users reported that setting
<finishWithCloseNotify>false</finishWithCloseNotify>in their XML configuration was being ignored when using-version DTLS12parameter.The root cause was that
ProtocolVersionDelegatewas unconditionally settingfinishWithCloseNotifyto true for all DTLS protocols, overriding any user-specified configuration.