From f7cc22c34cc60ae642e1b0c27db2a55f301c544b Mon Sep 17 00:00:00 2001
From: TLS-Attacker Developer <developer@tls-attacker.org>
Date: Mon, 30 Jun 2025 07:22:57 +0000
Subject: [PATCH] Fix variable hiding issues in BulkScanWorkerManager and
 MongoPersistenceProvider

- Renamed local variable 'instance' to 'manager' in BulkScanWorkerManager.handleStatic() to avoid shadowing the static field
- Renamed parameter 'serializers' to 'serializersToRegister' in MongoPersistenceProvider.registerSerializer() to avoid shadowing the static field
- Renamed parameter 'modules' to 'modulesToRegister' in MongoPersistenceProvider.registerModule() to avoid shadowing the static field

These changes resolve the variable hiding warnings identified in issue #17.
---
 .../de/rub/nds/crawler/core/BulkScanWorkerManager.java    | 4 ++--
 .../nds/crawler/persistence/MongoPersistenceProvider.java | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/main/java/de/rub/nds/crawler/core/BulkScanWorkerManager.java b/src/main/java/de/rub/nds/crawler/core/BulkScanWorkerManager.java
index 7ff0904..57c37e4 100644
--- a/src/main/java/de/rub/nds/crawler/core/BulkScanWorkerManager.java
+++ b/src/main/java/de/rub/nds/crawler/core/BulkScanWorkerManager.java
@@ -41,8 +41,8 @@ public static Future<Document> handleStatic(
             ScanJobDescription scanJobDescription,
             int parallelConnectionThreads,
             int parallelScanThreads) {
-        BulkScanWorkerManager instance = getInstance();
-        return instance.handle(scanJobDescription, parallelConnectionThreads, parallelScanThreads);
+        BulkScanWorkerManager manager = getInstance();
+        return manager.handle(scanJobDescription, parallelConnectionThreads, parallelScanThreads);
     }
 
     private final Cache<String, BulkScanWorker<?>> bulkScanWorkers;
diff --git a/src/main/java/de/rub/nds/crawler/persistence/MongoPersistenceProvider.java b/src/main/java/de/rub/nds/crawler/persistence/MongoPersistenceProvider.java
index aac8014..22c0999 100644
--- a/src/main/java/de/rub/nds/crawler/persistence/MongoPersistenceProvider.java
+++ b/src/main/java/de/rub/nds/crawler/persistence/MongoPersistenceProvider.java
@@ -64,8 +64,8 @@ public static void registerSerializer(JsonSerializer<?> serializer) {
         }
     }
 
-    public static void registerSerializer(JsonSerializer<?>... serializers) {
-        for (JsonSerializer<?> serializer : serializers) {
+    public static void registerSerializer(JsonSerializer<?>... serializersToRegister) {
+        for (JsonSerializer<?> serializer : serializersToRegister) {
             registerSerializer(serializer);
         }
     }
@@ -79,8 +79,8 @@ public static void registerModule(Module module) {
         }
     }
 
-    public static void registerModule(Module... modules) {
-        for (Module module : modules) {
+    public static void registerModule(Module... modulesToRegister) {
+        for (Module module : modulesToRegister) {
             registerModule(module);
         }
     }