Skip to content

Commit fedca25

Browse files
committed
Fix SpotBugs JLM_JSR166_UTILCONCURRENT_MONITORENTER in BulkScanWorker.init()
Replace synchronization on AtomicBoolean with dedicated lock object to address SpotBugs warning about synchronizing on util.concurrent instances.
1 parent 99fe25f commit fedca25

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/main/java/de/rub/nds/crawler/core/BulkScanWorker.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ public abstract class BulkScanWorker<T extends ScanConfig> {
2424
private final AtomicInteger activeJobs = new AtomicInteger(0);
2525
private final AtomicBoolean initialized = new AtomicBoolean(false);
2626
private final AtomicBoolean shouldCleanupSelf = new AtomicBoolean(false);
27+
private final Object initializationLock = new Object();
2728
protected final String bulkScanId;
2829
protected final T scanConfig;
2930

@@ -67,7 +68,7 @@ public final boolean init() {
6768
// synchronize such that no thread runs before being initialized
6869
// but only synchronize if not already initialized
6970
if (!initialized.get()) {
70-
synchronized (initialized) {
71+
synchronized (initializationLock) {
7172
if (!initialized.getAndSet(true)) {
7273
initInternal();
7374
return true;

0 commit comments

Comments
 (0)