Skip to content

Commit f7cc22c

Browse files
author
TLS-Attacker Developer
committed
Fix variable hiding issues in BulkScanWorkerManager and MongoPersistenceProvider
- Renamed local variable 'instance' to 'manager' in BulkScanWorkerManager.handleStatic() to avoid shadowing the static field - Renamed parameter 'serializers' to 'serializersToRegister' in MongoPersistenceProvider.registerSerializer() to avoid shadowing the static field - Renamed parameter 'modules' to 'modulesToRegister' in MongoPersistenceProvider.registerModule() to avoid shadowing the static field These changes resolve the variable hiding warnings identified in issue #17.
1 parent 47872ac commit f7cc22c

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/main/java/de/rub/nds/crawler/core/BulkScanWorkerManager.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ public static Future<Document> handleStatic(
4141
ScanJobDescription scanJobDescription,
4242
int parallelConnectionThreads,
4343
int parallelScanThreads) {
44-
BulkScanWorkerManager instance = getInstance();
45-
return instance.handle(scanJobDescription, parallelConnectionThreads, parallelScanThreads);
44+
BulkScanWorkerManager manager = getInstance();
45+
return manager.handle(scanJobDescription, parallelConnectionThreads, parallelScanThreads);
4646
}
4747

4848
private final Cache<String, BulkScanWorker<?>> bulkScanWorkers;

src/main/java/de/rub/nds/crawler/persistence/MongoPersistenceProvider.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ public static void registerSerializer(JsonSerializer<?> serializer) {
6464
}
6565
}
6666

67-
public static void registerSerializer(JsonSerializer<?>... serializers) {
68-
for (JsonSerializer<?> serializer : serializers) {
67+
public static void registerSerializer(JsonSerializer<?>... serializersToRegister) {
68+
for (JsonSerializer<?> serializer : serializersToRegister) {
6969
registerSerializer(serializer);
7070
}
7171
}
@@ -79,8 +79,8 @@ public static void registerModule(Module module) {
7979
}
8080
}
8181

82-
public static void registerModule(Module... modules) {
83-
for (Module module : modules) {
82+
public static void registerModule(Module... modulesToRegister) {
83+
for (Module module : modulesToRegister) {
8484
registerModule(module);
8585
}
8686
}

0 commit comments

Comments
 (0)