Skip to content

Commit 72df577

Browse files
committed
Fix STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE SpotBugs issue
Replace static SimpleDateFormat with thread-safe DateTimeFormatter in BulkScan class to fix SpotBugs warning about thread safety issues with static DateFormat instances.
1 parent 99fe25f commit 72df577

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/main/java/de/rub/nds/crawler/data/BulkScan.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@
1010

1111
import de.rub.nds.crawler.constant.JobStatus;
1212
import java.io.Serializable;
13-
import java.text.SimpleDateFormat;
1413
import java.time.Instant;
15-
import java.util.Date;
14+
import java.time.ZoneId;
15+
import java.time.format.DateTimeFormatter;
1616
import java.util.EnumMap;
1717
import java.util.Map;
1818
import javax.persistence.Id;
@@ -51,7 +51,8 @@ public class BulkScan implements Serializable {
5151

5252
private String crawlerVersion;
5353

54-
private static SimpleDateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd_HH-mm");
54+
private static final DateTimeFormatter DATE_FORMATTER =
55+
DateTimeFormatter.ofPattern("yyyy-MM-dd_HH-mm").withZone(ZoneId.systemDefault());
5556

5657
@SuppressWarnings("unused")
5758
private BulkScan() {}
@@ -71,8 +72,7 @@ public BulkScan(
7172
this.finished = false;
7273
this.startTime = startTime;
7374
this.monitored = monitored;
74-
this.collectionName =
75-
name + "_" + dateFormat.format(Date.from(Instant.ofEpochMilli(startTime)));
75+
this.collectionName = name + "_" + DATE_FORMATTER.format(Instant.ofEpochMilli(startTime));
7676
this.notifyUrl = notifyUrl;
7777
}
7878

0 commit comments

Comments
 (0)