add tests for get_language_code and getting default language (#142)

Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>

Author: MasterOdin

tests/test_tldr.py

@@ -31,3 +31,31 @@ def test_error_message():
         print("Test {}".format(pytest_wrapped_e))
         assert pytest_wrapped_e.type == SystemExit
         assert str(pytest_wrapped_e.value) == correct_output
+
+
+@pytest.mark.parametrize("language,expected", [
+    ("en_US.UTF-8", "en"),
+    ("en_US", "en"),
+    ("en", "en"),
+    ("pt_BR", "pt_BR"),
+    ("pt_PT", "pt_PT"),
+    ("zh_TW", "zh_TW"),
+    ("pt", "pt_PT")
+])
+def test_get_language_code(language, expected):
+    assert tldr.get_language_code(language) == expected
+
+
+@pytest.mark.parametrize("language,expected", [
+    ("en_US.UTF-8", "en"),
+    ("POSIX", None),
+    ("C", None)
+])
+def test_get_default_language(language, expected, monkeypatch):
+    monkeypatch.setenv("LANG", language)
+    assert tldr.get_default_language() == expected
+
+
+def test_get_default_language_unset(monkeypatch):
+    monkeypatch.delenv("LANG", raising=False)
+    assert tldr.get_default_language() is None

tldr.py

@@ -29,25 +29,6 @@
     'https://tldr-pages.github.io/assets/tldr.zip'
 )
 
-
-def get_language_code(language):
-    language = language.split('.')[0]
-    if language in ['pt_PT', 'pt_BR', 'zh_TW']:
-        return language
-    elif language == "pt":
-        return "pt_PT"
-    return language.split('_')[0]
-
-
-DEFAULT_LANG = get_language_code(
-    os.environ.get(
-        'LANG',
-        'C'
-    ))
-
-if DEFAULT_LANG == 'C' or DEFAULT_LANG == 'POSIX':
-    DEFAULT_LANG = None
-
 USE_CACHE = int(os.environ.get('TLDR_CACHE_ENABLED', '1')) > 0
 MAX_CACHE_AGE = int(os.environ.get('TLDR_CACHE_MAX_AGE', 24))
 
@@ -65,6 +46,29 @@ def get_language_code(language):
 }
 
 
+def get_language_code(language):
+    language = language.split('.')[0]
+    if language in ['pt_PT', 'pt_BR', 'zh_TW']:
+        return language
+    elif language == "pt":
+        return "pt_PT"
+    return language.split('_')[0]
+
+
+def get_default_language():
+    default_lang = get_language_code(
+        os.environ.get(
+            'LANG',
+            'C'
+        )
+    )
+
+    if default_lang == 'C' or default_lang == 'POSIX':
+        default_lang = None
+
+    return default_lang
+
+
 def get_cache_dir():
     if not os.environ.get('XDG_CACHE_HOME', False):
         if not os.environ.get('HOME', False):
@@ -175,9 +179,11 @@ def get_language_list():
         get_language_code,
         filter(lambda x: not (x == 'C' or x == 'POSIX' or x == ''), languages)
     ))
-    if DEFAULT_LANG is not None:
-        if DEFAULT_LANG not in languages:
-            languages.append(DEFAULT_LANG)
+
+    default_lang = get_default_language()
+
+    if default_lang is not None and default_lang not in languages:
+        languages.append(default_lang)
     else:
         languages = []
     if 'en' not in languages:
@@ -306,7 +312,8 @@ def output(page):
 
 def update_cache(language=None):
     if language is None:
-        language = DEFAULT_LANG if DEFAULT_LANG is not None else 'en'
+        default_lang = get_default_language()
+        language = default_lang if default_lang is not None else 'en'
     elif isinstance(language, list):
         language = language[0]
     try: