Fixing failing tests (#151)

* Update unit tests to match breaking changes in sinon.
* Pin dependencies' versions to minor releases.
  Automatically keeping up to the latest versions may break code (and has done so before).
  When needed, we can always intentionally upgrade the packages.

Author: agnivade

package.json

@@ -63,11 +63,11 @@
     "unzip2": "~0.2.5"
   },
   "devDependencies": {
-    "env-test": "*",
-    "eslint": "*",
-    "husky": "*",
-    "mocha": "*",
-    "should": "*",
-    "sinon": "*"
+    "env-test": "^1.0.0",
+    "eslint": "^4.6.1",
+    "husky": "^0.14.3",
+    "mocha": "^3.5.0",
+    "should": "^13.0.1",
+    "sinon": "^3.2.1"
   }
 }

test/cache.spec.js

@@ -42,11 +42,11 @@ describe('Cache', () => {
     });
 
     it('should return page contents for ls', (done) => {
-      sinon.stub(fs, 'readFile', (path, encoding, cb) => {
+      sinon.stub(fs, 'readFile').callsFake((path, encoding, cb) => {
         return cb(null, '# ls\n> ls page');
       });
       sinon.stub(platform, 'getPreferredPlatformFolder').returns('osx');
-      sinon.stub(index, 'findPlatform', (page, preferredPlatform, done) => {
+      sinon.stub(index, 'findPlatform').callsFake((page, preferredPlatform, done) => {
         return done('osx');
       });
       cache.getPage('ls', (err, content) => {
@@ -61,11 +61,11 @@ describe('Cache', () => {
     });
 
     it('should return empty contents for svcs on OSX', (done) =>{
-      sinon.stub(fs, 'readFile', (path, encoding, cb) => {
+      sinon.stub(fs, 'readFile').callsFake((path, encoding, cb) => {
         return cb(null, '# svcs\n> svcs');
       });
       sinon.stub(platform, 'getPreferredPlatformFolder').returns('osx');
-      sinon.stub(index, 'findPlatform', (page, preferredPlatform, done) => {
+      sinon.stub(index, 'findPlatform').callsFake((page, preferredPlatform, done) => {
         return done(null);
       });
       cache.getPage('svc', (err, content) => {
@@ -79,11 +79,11 @@ describe('Cache', () => {
     });
 
     it('should return page contents for svcs on SunOS', (done) => {
-      sinon.stub(fs, 'readFile', (path, encoding, cb) => {
+      sinon.stub(fs, 'readFile').callsFake((path, encoding, cb) => {
         return cb(null, '# svcs\n> svcs');
       });
       sinon.stub(platform, 'getPreferredPlatformFolder').returns('sunos');
-      sinon.stub(index, 'findPlatform', (page, preferredPlatform, done) => {
+      sinon.stub(index, 'findPlatform').callsFake((page, preferredPlatform, done) => {
         return done('svcs');
       });
       cache.getPage('svcs', (err, content) => {

test/index.spec.js

@@ -26,10 +26,10 @@ describe('Index', () => {
         'sunos/du.md',
         'sunos/svcs.md'
       ]);
-    sinon.stub(fs, 'readFile', (path, encoding, cb) => {
+    sinon.stub(fs, 'readFile').callsFake((path, encoding, cb) => {
       return cb('dummy error', null);
     });
-    sinon.stub(fs, 'writeFile', (path, contents, cb) => {
+    sinon.stub(fs, 'writeFile').callsFake((path, contents, cb) => {
       return cb();
     });
   });