upgrade correctly to eslint v9 (#465)

* upgrade correctly to eslint v9

* drop Node v16

* add Node v22

Author: sebastiaanspeck

.eslintrc.json

@@ -0,0 +1,32 @@
+export default [
+    {
+      "files": ["bin/tldr"],
+      "rules": {
+        "indent": ["error", 2],
+        "quotes": ["error", "single"],
+        "linebreak-style": ["error", "unix"],
+        "semi": ["error", "always"],
+        "no-console": "off",
+        "arrow-parens": ["error", "always"],
+        "arrow-body-style": ["error", "always"],
+        "array-callback-return": "error",
+        "no-magic-numbers": ["error", {
+          "ignore": [-1, 0, 1, 2],
+          "ignoreArrayIndexes": true,
+          "detectObjects": true
+        }],
+        "no-var": "error",
+        "no-warning-comments": "warn",
+        "handle-callback-err": "error"
+      },
+      "languageOptions": {
+        "ecmaVersion": "latest",
+        "sourceType": "module",
+        "globals": {
+          "node": true,
+          "mocha": true,
+          "es2019": true
+        }
+      }
+    }
+  ];

eslint.config.mjs

@@ -65,7 +65,7 @@ class Cache {
           index.rebuildPagesIndex(),
         ]);
       })
-      // eslint-disable-next-line no-unused-vars
+       
       .then(([_, shortIndex]) => {
         return shortIndex;
       });

lib/cache.js

@@ -18,7 +18,7 @@ Local cache is empty
 Please run tldr --update
     `);
     this.name = 'EmptyCacheError';
-    // eslint-disable-next-line no-magic-numbers
+     
     this.code = 2;
   }
 }
@@ -30,7 +30,7 @@ Page not found.
 If you want to contribute it, feel free to send a pull request to: ${repo}
     `);
     this.name = 'MissingPageError';
-    // eslint-disable-next-line no-magic-numbers
+     
     this.code = 3;
   }
 }
@@ -39,7 +39,7 @@ class MissingRenderPathError extends TldrError {
   constructor() {
     super('Option --render needs an argument.');
     this.name = 'MissingRenderPathError';
-    // eslint-disable-next-line no-magic-numbers
+     
     this.code = 4;
   }
 }
@@ -48,7 +48,7 @@ class UnsupportedShellError extends TldrError {
   constructor(shell, supportedShells) {
     super(`Unsupported shell: ${shell}. Supported shells are: ${supportedShells.join(', ')}`);
     this.name = 'UnsupportedShellError';
-    // eslint-disable-next-line no-magic-numbers
+     
     this.code = 5;
   }
 }
@@ -57,7 +57,7 @@ class CompletionScriptError extends TldrError {
   constructor(message) {
     super(message);
     this.name = 'CompletionScriptError';
-    // eslint-disable-next-line no-magic-numbers
+     
     this.code = 6;
   }
 }

lib/errors.js

@@ -91,7 +91,7 @@ module.exports = {
     });
   },
 
-  // eslint-disable-next-line no-magic-numbers
+   
   uniqueId(length = 32) {
     const size = Math.ceil(length / 2);
     return crypto.randomBytes(size).toString('hex').slice(0, length);