Add eslint-plugin-unicorn

Author: tkrotoff

.eslintrc.js

@@ -6,6 +6,7 @@ const config = {
   parserOptions: {},
   extends: [
     // /!\ Order matters: the next one overrides rules from the previous one
+    'plugin:unicorn/recommended',
     'plugin:jest/recommended',
     'airbnb',
     // Already done by Airbnb
@@ -104,6 +105,14 @@ const config = {
     '@typescript-eslint/ban-ts-ignore': 'off',
     '@typescript-eslint/explicit-module-boundary-types': 'off',
 
+    'unicorn/filename-case': 'off',
+    'unicorn/prevent-abbreviations': 'off',
+    'unicorn/catch-error-name': 'off',
+    // [IE does not support for...of](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...of#Browser_compatibility)
+    'unicorn/no-for-loop': 'off',
+    'unicorn/no-null': 'off',
+    'unicorn/prefer-query-selector': 'off',
+
     'jsx-a11y/label-has-associated-control': 'off',
 
     'react/no-unescaped-entities': 'off',

examples/Bootstrap4/App.jsx

@@ -29,18 +29,18 @@ async function checkUsernameAvailability(value) {
   return !['john', 'paul', 'george', 'ringo'].includes(value.toLowerCase());
 }
 
+function getInitialInputsState() {
+  return {
+    username: '',
+    password: '',
+    passwordConfirm: ''
+  };
+}
+
 function Form() {
   const form = useRef(null);
   const password = useRef(null);
 
-  function getInitialInputsState() {
-    return {
-      username: '',
-      password: '',
-      passwordConfirm: ''
-    };
-  }
-
   const [inputs, setInputs] = useState(getInitialInputsState());
   const [signUpButtonDisabled, setSignUpButtonDisabled] = useState(false);
   const [resetButtonDisabled, setResetButtonDisabled] = useState(true);

examples/Bootstrap4/App.test.e2e.js

@@ -5,7 +5,7 @@ jest.setTimeout(20000); // 20s
 function indent(text, indentation) {
   // [Add a char to the start of each line in JavaScript using regular expression](https://stackoverflow.com/q/11939575)
   // [Trim trailing spaces before newlines in a single multi-line string in JavaScript](https://stackoverflow.com/q/5568797)
-  return text.replace(/^/gm, indentation).replace(/[^\S\r\n]+$/gm, '');
+  return text.replace(/^/gm, indentation).replace(/[^\S\n\r]+$/gm, '');
 }
 
 beforeEach(async () => {

examples/MaterialUI/App.tsx

@@ -56,18 +56,18 @@ interface InputsState {
   passwordConfirm: string;
 }
 
+function getInitialInputsState() {
+  return {
+    username: '',
+    password: '',
+    passwordConfirm: ''
+  };
+}
+
 function Form({ classes }: FormProps) {
   const form = useRef<FormWithConstraints | null>(null);
   const password = useRef<HTMLInputElement | null>(null);
 
-  function getInitialInputsState() {
-    return {
-      username: '',
-      password: '',
-      passwordConfirm: ''
-    };
-  }
-
   const [inputs, setInputs] = useState<InputsState>(getInitialInputsState());
   const [signUpButtonDisabled, setSignUpButtonDisabled] = useState(false);
   const [resetButtonDisabled, setResetButtonDisabled] = useState(true);

examples/Password/App.test.e2e.ts

@@ -4,7 +4,7 @@ jest.setTimeout(20000); // 20s
 function indent(text: string, indentation: string) {
   // [Add a char to the start of each line in JavaScript using regular expression](https://stackoverflow.com/q/11939575)
   // [Trim trailing spaces before newlines in a single multi-line string in JavaScript](https://stackoverflow.com/q/5568797)
-  return text.replace(/^/gm, indentation).replace(/[^\S\r\n]+$/gm, '');
+  return text.replace(/^/gm, indentation).replace(/[^\S\n\r]+$/gm, '');
 }
 
 beforeEach(async () => {

examples/SignUp/App.tsx

@@ -67,7 +67,7 @@ class SignUp extends React.Component<Props, State> {
     return {
       // en-US => en, fr-FR => fr
       // eslint-disable-next-line react/destructuring-assignment
-      language: this.props.i18n.language.substring(0, 2),
+      language: this.props.i18n.language.slice(0, 2),
 
       firstName: '',
       lastName: '',
@@ -141,11 +141,9 @@ class SignUp extends React.Component<Props, State> {
     target: HTMLInputElement | HTMLSelectElement | HTMLTextAreaElement,
     forceValidateFields: boolean
   ) {
-    if (forceValidateFields) {
-      await this.form!.validateFields(target);
-    } else {
-      await this.form!.validateFieldsWithoutFeedback(target);
-    }
+    await (forceValidateFields
+      ? this.form!.validateFields(target)
+      : this.form!.validateFieldsWithoutFeedback(target));
 
     this.setState(prevState => ({
       signUpButtonDisabled: !this.form!.isValid(),
@@ -170,11 +168,9 @@ class SignUp extends React.Component<Props, State> {
 
     if (forceValidateFields) this.form!.resetFields(target);
 
-    if (_debounce) {
-      await this.validateFieldsWithDebounce(target, forceValidateFields);
-    } else {
-      await this.validateFieldsWithoutDebounce(target, forceValidateFields);
-    }
+    await (_debounce
+      ? this.validateFieldsWithDebounce(target, forceValidateFields)
+      : this.validateFieldsWithoutDebounce(target, forceValidateFields));
   }
 
   handleHasWebsiteChange = (e: React.ChangeEvent<HTMLInputElement>) => {

package.json

@@ -47,6 +47,7 @@
     "eslint-plugin-react": "^7.21.4",
     "eslint-plugin-react-hooks": "^4.1.2",
     "eslint-plugin-simple-import-sort": "^5.0.3",
+    "eslint-plugin-unicorn": "^23.0.0",
     "husky": "^4.3.0",
     "lerna": "^3.22.1",
     "npm-run-all": "^4.1.5",

packages/react-form-with-constraints-bootstrap4/src/FieldFeedbacksEnzymeFix.tsx

@@ -1,6 +1,6 @@
 import * as React from 'react';
 
-import { FieldFeedbacks } from './index';
+import { FieldFeedbacks } from '.';
 
 // FIXME [React 16 Fragments unsupported](https://github.com/airbnb/enzyme/issues/1213)
 export class FieldFeedbacksEnzymeFix extends FieldFeedbacks {

packages/react-form-with-constraints-bootstrap4/src/SignUp.tsx

@@ -1,8 +1,8 @@
 import * as React from 'react';
 
 import { checkUsernameAvailability } from '../../react-form-with-constraints/src/checkUsernameAvailability';
+import { Async, FieldFeedback, FormWithConstraints, Input } from '.';
 import { FieldFeedbacksEnzymeFix as FieldFeedbacks } from './FieldFeedbacksEnzymeFix';
-import { Async, FieldFeedback, FormWithConstraints, Input } from './index';
 
 export class SignUp extends React.Component {
   form: FormWithConstraints | null = null;

packages/react-form-with-constraints-material-ui/src/FieldFeedbacksEnzymeFix.tsx

@@ -1,6 +1,6 @@
 import * as React from 'react';
 
-import { FieldFeedbacks } from './index';
+import { FieldFeedbacks } from '.';
 
 // FIXME [React 16 Fragments unsupported](https://github.com/airbnb/enzyme/issues/1213)
 export class FieldFeedbacksEnzymeFix extends FieldFeedbacks {