Merge pull request #894 from tkhq/ethan/utils-unit-tests-v1

started adding unit tests for util functions

Author: ethankonk

packages/core/jest.config.js

@@ -0,0 +1,11 @@
+/** @type {import("@jest/types").Config.InitialOptions} */
+const config = {
+  transform: {
+    "\\.[jt]sx?$": "@turnkey/jest-config/transformer.js",
+  },
+  testMatch: ["**/__tests__/**/*-(spec|test).[jt]s?(x)"],
+  testPathIgnorePatterns: ["<rootDir>/dist/", "<rootDir>/node_modules/"],
+  testTimeout: 30 * 1000, // For slow CI machines
+};
+
+module.exports = config;

packages/core/package.json

@@ -14,7 +14,8 @@
     "build": "rollup -c",
     "clean": "rimraf ./dist ./.cache",
     "typecheck": "tsc -p tsconfig.typecheck.json",
-    "prepublishOnly": "pnpm run clean && pnpm run build"
+    "prepublishOnly": "pnpm run clean && pnpm run build",
+    "test": "jest"
   },
   "keywords": [
     "turnkey"

packages/core/src/__tests__/utils-test.ts

@@ -0,0 +1,93 @@
+import { isWeb, isReactNative } from "../utils";
+import {
+  describe,
+  expect,
+  jest,
+  beforeEach,
+  afterEach,
+  it,
+} from "@jest/globals";
+
+describe("platform detection", () => {
+  const g = globalThis as any;
+
+  const saveGlobals = () => ({
+    window: g.window,
+    document: g.document,
+    navigator: g.navigator,
+  });
+
+  const restoreGlobals = (orig: any) => {
+    if (typeof orig.window === "undefined") delete g.window;
+    else g.window = orig.window;
+
+    if (typeof orig.document === "undefined") delete g.document;
+    else g.document = orig.document;
+
+    if (typeof orig.navigator === "undefined") delete g.navigator;
+    else g.navigator = orig.navigator;
+  };
+
+  let orig: any;
+
+  beforeEach(() => {
+    orig = saveGlobals();
+    // Start clean: no browser-like globals unless a test sets them.
+    delete g.window;
+    delete g.document;
+    delete g.navigator;
+    jest.resetModules(); // ensures fresh imports if needed later
+  });
+
+  afterEach(() => {
+    restoreGlobals(orig);
+    jest.restoreAllMocks();
+  });
+
+  it("returns false for both on plain Node (no globals)", () => {
+    expect(isWeb()).toBe(false);
+    expect(isReactNative()).toBe(false);
+  });
+
+  it("isWeb() true when window and document exist", () => {
+    g.window = {}; // minimal stubs are fine since you only check typeof
+    g.document = {};
+    expect(isWeb()).toBe(true);
+    expect(isReactNative()).toBe(false);
+  });
+
+  it("isWeb() false if only window exists", () => {
+    g.window = {};
+    expect(isWeb()).toBe(false);
+  });
+
+  it("isWeb() false if only document exists", () => {
+    g.document = {};
+    expect(isWeb()).toBe(false);
+  });
+
+  it("isReactNative() true when navigator.product === 'ReactNative'", () => {
+    g.navigator = { product: "ReactNative" };
+    expect(isReactNative()).toBe(true);
+    expect(isWeb()).toBe(false);
+  });
+
+  it("isReactNative() false when navigator exists but product differs", () => {
+    g.navigator = { product: "Gecko" };
+    expect(isReactNative()).toBe(false);
+  });
+
+  it("isReactNative() false when navigator missing", () => {
+    expect(isReactNative()).toBe(false);
+  });
+
+  it("does not accidentally treat web + RN at the same time", () => {
+    g.window = {};
+    g.document = {};
+    g.navigator = { product: "ReactNative" };
+    // Your current logic would report both true; assert current behavior or
+    // change requirements. Here we assert the current behavior explicitly.
+    expect(isWeb()).toBe(true);
+    expect(isReactNative()).toBe(true);
+  });
+});

packages/core/src/utils.ts

@@ -26,7 +26,7 @@ import {
   EvmChainInfo,
   SolanaChainInfo,
   Curve,
-} from "@types";
+} from "./__types__/base";
 import bs58 from "bs58";
 
 // Import all defaultAccountAtIndex functions for each address format