Skip to content

Commit 83866be

Browse files
authored
Resolves #194. Introduces Revapi into the build process. (#195)
- Switching to verify goal in main.yml.
1 parent 5135cff commit 83866be

File tree

3 files changed

+27
-4
lines changed

3 files changed

+27
-4
lines changed

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,6 @@ jobs:
2323
if: contains(matrix.os, 'win') == false
2424
run: chmod +x ./mvnw
2525
- name: Build with Maven
26-
run: ./mvnw package --file library/pom.xml --batch-mode
26+
run: ./mvnw verify --file library/pom.xml --batch-mode
2727
env:
2828
MAVEN_OPTS: -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn

library/pom.xml

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,29 @@
165165
</execution>
166166
</executions>
167167
</plugin>
168+
<plugin>
169+
<groupId>org.revapi</groupId>
170+
<artifactId>revapi-maven-plugin</artifactId>
171+
<version>0.14.3</version>
172+
<dependencies>
173+
<dependency>
174+
<groupId>org.revapi</groupId>
175+
<artifactId>revapi-java</artifactId>
176+
<version>0.24.2</version>
177+
</dependency>
178+
</dependencies>
179+
<configuration>
180+
<oldArtifacts>
181+
<artifact>com.j2html:j2html:1.5.0</artifact>
182+
</oldArtifacts>
183+
</configuration>
184+
<executions>
185+
<execution>
186+
<id>check</id>
187+
<goals><goal>check</goal></goals>
188+
</execution>
189+
</executions>
190+
</plugin>
168191
</plugins>
169192
</build>
170193

library/src/main/java/j2html/utils/JSMin.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -288,13 +288,13 @@ public void jsmin() throws IOException, UnterminatedRegExpLiteralException, Unte
288288
out.flush();
289289
}
290290

291-
private class UnterminatedCommentException extends Exception {
291+
public class UnterminatedCommentException extends Exception {
292292
}
293293

294-
private class UnterminatedStringLiteralException extends Exception {
294+
public class UnterminatedStringLiteralException extends Exception {
295295
}
296296

297-
private class UnterminatedRegExpLiteralException extends Exception {
297+
public class UnterminatedRegExpLiteralException extends Exception {
298298
}
299299

300300
}

0 commit comments

Comments
 (0)