fix: make endpoint 0 stall not a noop

Author: mikesmitty

src/machine/usb.go

@@ -217,9 +217,8 @@ func handleStandardSetup(setup usb.Setup) bool {
 		} else if setup.WValueL == 0 { // ENDPOINTHALT
 			if usbStallHandler[setup.WIndex&0x7F] != nil {
 				return usbStallHandler[setup.WIndex&0x7F](setup)
-			} else {
-				isEndpointHalt = false
 			}
+			isEndpointHalt = false
 		}
 		SendZlp()
 		return true
@@ -230,9 +229,8 @@ func handleStandardSetup(setup usb.Setup) bool {
 		} else if setup.WValueL == 0 { // ENDPOINTHALT
 			if usbStallHandler[setup.WIndex&0x7F] != nil {
 				return usbStallHandler[setup.WIndex&0x7F](setup)
-			} else {
-				isEndpointHalt = true
 			}
+			isEndpointHalt = true
 		}
 		SendZlp()
 		return true

src/machine/usb/msc/msc.go

@@ -204,7 +204,7 @@ func (m *msc) run(b []byte, isEpOut bool) {
 			m.state = mscStateNeedReset
 			m.stallEndpoint(usb.MSC_ENDPOINT_IN)
 			m.stallEndpoint(usb.MSC_ENDPOINT_OUT)
-			m.stallEndpoint(0)
+			m.stallEndpoint(usb.CONTROL_ENDPOINT)
 			return
 		}
 

src/machine/usb/msc/setup.go

@@ -121,6 +121,8 @@ func (m *msc) stallEndpoint(ep uint8) {
 	} else if ep == usb.MSC_ENDPOINT_OUT {
 		m.rxStalled = true
 		machine.SetStallEPOut(usb.MSC_ENDPOINT_OUT)
+	} else if ep == usb.CONTROL_ENDPOINT {
+		machine.SetStallEPIn(usb.CONTROL_ENDPOINT)
 	}
 }