fix: keep direction masking consistent

Author: mikesmitty

src/machine/usb.go

@@ -213,11 +213,11 @@ func handleStandardSetup(setup usb.Setup) bool {
 		if setup.WValueL == 1 { // DEVICEREMOTEWAKEUP
 			isRemoteWakeUpEnabled = false
 		} else if setup.WValueL == 0 { // ENDPOINTHALT
-			if setup.WIndex < usb.NumberOfEndpoints && usbStallHandler[setup.WIndex&0x7F] != nil {
+			if idx := setup.WIndex & 0x7F; idx < usb.NumberOfEndpoints && usbStallHandler[idx] != nil {
 				// Host has requested to clear an endpoint stall. If the request is addressed to
 				// an endpoint with a configured StallHandler, forward the message on.
 				// The 0x7F mask is used to clear the direction bit from the endpoint number
-				return usbStallHandler[setup.WIndex&0x7F](setup)
+				return usbStallHandler[idx](setup)
 			}
 			isEndpointHalt = false
 		}
@@ -228,11 +228,11 @@ func handleStandardSetup(setup usb.Setup) bool {
 		if setup.WValueL == 1 { // DEVICEREMOTEWAKEUP
 			isRemoteWakeUpEnabled = true
 		} else if setup.WValueL == 0 { // ENDPOINTHALT
-			if setup.WIndex < usb.NumberOfEndpoints && usbStallHandler[setup.WIndex&0x7F] != nil {
+			if idx := setup.WIndex & 0x7F; idx < usb.NumberOfEndpoints && usbStallHandler[idx] != nil {
 				// Host has requested to stall an endpoint. If the request is addressed to
 				// an endpoint with a configured StallHandler, forward the message on.
 				// The 0x7F mask is used to clear the direction bit from the endpoint number
-				return usbStallHandler[setup.WIndex&0x7F](setup)
+				return usbStallHandler[idx](setup)
 			}
 			isEndpointHalt = true
 		}