fix ParseUUID. Return error for invalid UUID strings

oflebbe · deadprogram · commit 5bedd1dccc33 · 2020-09-14T23:19:52.000+02:00
diff --git a/uuid.go b/uuid.go
@@ -115,12 +115,12 @@ func ParseUUID(s string) (uuid UUID, err error) {
 		uuid[3-uuidIndex/8] |= uint32(nibble) << (4 * (7 - uuidIndex%8))
 		uuidIndex++
 	}
-	if uuidIndex != 31 {
+	if uuidIndex != 32 {
 		// The UUID doesn't have exactly 32 nibbles. Perhaps a 16-bit or 32-bit
 		// UUID?
 		err = errInvalidUUID
 	}
-	return uuid, nil
+	return
 }
 
 // String returns a human-readable version of this UUID, such as

Original file line number	Diff line number	Diff line change
`@@ -115,12 +115,12 @@ func ParseUUID(s string) (uuid UUID, err error) {`
`115`	`115`	`uuid[3-uuidIndex/8] \|= uint32(nibble) << (4 * (7 - uuidIndex%8))`
`116`	`116`	`uuidIndex++`
`117`	`117`	`}`
`118`		`- if uuidIndex != 31 {`
	`118`	`+ if uuidIndex != 32 {`
`119`	`119`	`// The UUID doesn't have exactly 32 nibbles. Perhaps a 16-bit or 32-bit`
`120`	`120`	`// UUID?`
`121`	`121`	`err = errInvalidUUID`
`122`	`122`	`}`
`123`		`- return uuid, nil`
	`123`	`+ return`
`124`	`124`	`}`
`125`	`125`
`126`	`126`	`// String returns a human-readable version of this UUID, such as`