Skip to content

Commit b5b4856

Browse files
authored
Better error handling when parallel proc fails
1 parent e21cae8 commit b5b4856

File tree

3 files changed

+16
-4
lines changed

3 files changed

+16
-4
lines changed

src/mkdocs_git_revision_date_localized_plugin/plugin.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -180,10 +180,14 @@ def on_files(self, files: Files, config: MkDocsConfig):
180180
else:
181181
original_source = None
182182

183-
if not self.last_revision_commits:
184-
self.parallel_compute_commit_timestamps(files=files, original_source=original_source, is_first_commit=False)
185-
if not self.created_commits:
186-
self.parallel_compute_commit_timestamps(files=files, original_source=original_source, is_first_commit=True)
183+
try:
184+
if not self.last_revision_commits:
185+
self.parallel_compute_commit_timestamps(files=files, original_source=original_source, is_first_commit=False)
186+
if not self.created_commits:
187+
self.parallel_compute_commit_timestamps(files=files, original_source=original_source, is_first_commit=True)
188+
except Exception as e:
189+
logging.warning(f"Parallel processing failed: {str(e)}.\n To fall back to serial processing, use 'enable_parallel_processing: False' setting.")
190+
187191

188192
def on_page_markdown(self, markdown: str, page: Page, config: config_options.Config, files, **kwargs) -> str:
189193
"""
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
site_name: test gitrevisiondatelocalized_plugin
2+
use_directory_urls: true
3+
4+
plugins:
5+
- search
6+
- git-revision-date-localized:
7+
enable_parallel_processing: False

tests/test_builds.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -333,6 +333,7 @@ def validate_mkdocs_file(temp_path: str, mkdocs_yml_file: str):
333333
"basic_project/mkdocs_fallback_to_build_date.yml",
334334
"basic_project/mkdocs_locale.yml",
335335
"basic_project/mkdocs_meta.yml",
336+
"basic_project/mkdocs_no_parallel.yml",
336337
"basic_project/mkdocs_plugin_locale.yml",
337338
"basic_project/mkdocs.yml",
338339
"basic_project/mkdocs_theme_timeago_locale.yml",

0 commit comments

Comments
 (0)