Update: include description + test case

Author: till

go.mod

@@ -6,13 +6,15 @@ toolchain go1.24.1
 
 require (
 	github.com/go-redis/redis/v8 v8.11.5
+	github.com/stretchr/testify v1.9.0
 	github.com/tailscale/go-bluesky v0.0.0-20241115170709-693553a07285
 )
 
 require (
 	github.com/carlmjohnson/versioninfo v0.22.5 // indirect
 	github.com/cespare/xxhash/v2 v2.2.0 // indirect
 	github.com/cpuguy83/go-md2man/v2 v2.0.5 // indirect
+	github.com/davecgh/go-spew v1.1.1 // indirect
 	github.com/dgryski/go-rendezvous v0.0.0-20200823014737-9f7001d12a5f // indirect
 	github.com/dustin/go-humanize v1.0.1 // indirect
 	github.com/felixge/httpsnoop v1.0.4 // indirect
@@ -26,6 +28,7 @@ require (
 	github.com/klauspost/compress v1.18.0 // indirect
 	github.com/minio/crc64nvme v1.0.1 // indirect
 	github.com/minio/md5-simd v1.1.2 // indirect
+	github.com/pmezard/go-difflib v1.0.0 // indirect
 	github.com/rs/xid v1.6.0 // indirect
 	github.com/russross/blackfriday/v2 v2.1.0 // indirect
 	github.com/xrash/smetrics v0.0.0-20240521201337-686a1a2994c1 // indirect
@@ -38,6 +41,7 @@ require (
 	golang.org/x/text v0.23.0 // indirect
 	google.golang.org/appengine v1.6.7 // indirect
 	google.golang.org/protobuf v1.33.0 // indirect
+	gopkg.in/yaml.v3 v3.0.1 // indirect
 )
 
 require (

internal/bluesky/bluesky.go

@@ -22,7 +22,7 @@ type Client struct {
 
 // PostRecord constructs a post record with a facet. To get there, it will find the
 // position of the URL inside the text and attaches it to the post.
-func PostRecord(title, url, author, stargazers, hashtags string) *bsky.FeedPost {
+func PostRecord(title, description, url, author, stargazers, hashtags string) *bsky.FeedPost {
 	text := title
 
 	var startAuthor int64 = -1
@@ -36,6 +36,17 @@ func PostRecord(title, url, author, stargazers, hashtags string) *bsky.FeedPost
 		text += fmt.Sprintf(" (%s)", stargazers)
 	}
 
+	// 300 = limit + '#go'
+	if len(text) < (300-3) && len(description) > 0 {
+		// poor version of normalize
+		description = strings.Join(strings.Fields(description), " ")
+		if len(description) > 150 {
+			text += "\n\n" + description[0:147] + "..."
+		} else {
+			text += "\n\n" + description
+		}
+	}
+
 	if len(hashtags) > 0 {
 		text += "\n\n" + hashtags
 	}
@@ -57,7 +68,7 @@ func PostRecord(title, url, author, stargazers, hashtags string) *bsky.FeedPost
 	}
 
 	if len(hashtags) > 0 {
-		allTags := strings.Split(hashtags, " ")
+		allTags := strings.Fields(hashtags)
 
 		startHashTag := int64(strings.Index(text, hashtags))
 
@@ -172,13 +183,16 @@ func handleError(ctx context.Context, err error) error {
 	var netErr *net.OpError
 	if errors.As(err, &netErr) {
 		if netErr.Temporary() {
+			slog.InfoContext(ctx, "temporary error: "+netErr.Error())
 			return nil
 		}
 
 		if netErr.Timeout() {
+			slog.InfoContext(ctx, "timeout error: "+netErr.Error())
 			return nil
 		}
 
+		// unhandled net error
 		slog.ErrorContext(ctx, netErr.Error())
 		return err
 	}

internal/bluesky/bluesky_test.go

@@ -0,0 +1,61 @@
+package bluesky_test
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/till/golangoss-bluesky/internal/bluesky"
+)
+
+type testCase struct {
+	Title          string
+	Description    string
+	URL            string
+	Author         string
+	Stargazers     string
+	Tag            string
+	ExpectedFacets int
+}
+
+func TestPostRecord(t *testing.T) {
+	testCases := []testCase{
+		{
+			Title:          "simple",
+			Description:    "description",
+			URL:            "https://github.com/user/repo",
+			Author:         "@user",
+			Stargazers:     "1 ⭐️",
+			Tag:            "#go",
+			ExpectedFacets: 3,
+		},
+		{
+			Title:          "extra-long-description",
+			Description:    "description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description, description",
+			URL:            "https://github.com/org/repo",
+			Author:         "",
+			Stargazers:     "1 ⭐️",
+			Tag:            "#go",
+			ExpectedFacets: 2,
+		},
+		{
+			Title:          "Short",
+			URL:            "https://github.com/s/s",
+			Author:         "",
+			Stargazers:     "0 ⭐️",
+			Tag:            "",
+			ExpectedFacets: 1,
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.Title, func(t *testing.T) {
+			record := bluesky.PostRecord(tc.Title, tc.Description, tc.URL, tc.Author, tc.Stargazers, tc.Tag)
+			assert.NotNil(t, record)
+
+			assert.NotEmpty(t, record.CreatedAt)
+			assert.Len(t, record.Facets, tc.ExpectedFacets)
+
+			assert.True(t, (len(record.Text) <= 300))
+		})
+	}
+}

internal/content/content.go

@@ -55,9 +55,8 @@ func Do(ctx context.Context, c bluesky.Client) error {
 				stargazers = e
 				continue
 			}
-
 		}
 	}
 
-	return c.Post(ctx, bluesky.PostRecord(*p.Title, *p.URL, author, stargazers, hashTags))
+	return c.Post(ctx, bluesky.PostRecord(*p.Title, *p.Subtitle, *p.URL, author, stargazers, hashTags))
 }