Fix version comparison (#5376)

* Reimplement #5367

* Override default density method

Author: teunbrand

NEWS.md

@@ -1,3 +1,8 @@
+# ggplot2 3.4.3
+
+This hotfix release addresses a version comparison change in r-devel. There are
+no user-facing or breaking changes.
+
 # ggplot2 3.4.2
 This is a hotfix release anticipating changes in r-devel, but folds in upkeep
 changes and a few bug fixes as well.

R/backports.R

@@ -1,6 +1,6 @@
 # Backport fix from R 3.3:
 # https://github.com/wch/r-source/commit/4efc81c98d262f93de9e7911aaa910f5c63cd00f
-if (getRversion() < 3.3) {
+if (getRversion() < "3.3") {
   absolute.units <- getFromNamespace("absolute.units", "grid")
   absolute.units.unit <- getFromNamespace("absolute.units.unit", "grid")
   absolute.units.unit.list <- getFromNamespace("absolute.units.unit.list", "grid")
@@ -18,6 +18,6 @@ if (getRversion() < 3.3) {
 on_load(backport_unit_methods())
 
 # isFALSE() is available on R (>=3.5)
-if (getRversion() < 3.5) {
+if (getRversion() < "3.5") {
   isFALSE <- function(x) is.logical(x) && length(x) == 1L && !is.na(x) && !x
 }

tests/testthat/helper-density.R

@@ -0,0 +1,21 @@
+
+# In R devel from 4.3.0 onwards, the density calculation has slightly changed,
+# which affects visual snapshots that use a density calculation, like
+# `geom_violin()` and `geom_density()`.
+# See https://developer.r-project.org/blosxom.cgi/R-devel/NEWS/2023/05/03#n2023-05-03
+#
+# It has a backwards compatibility argument called 'old.coords' that can be used
+# to perform the classic density calculation, which means we can stably use
+# visual tests in R devel.
+#
+# Since that argument is not available in older versions, we have to use the
+# following workaround. Here, we conditionally override the default
+# density method to use `old.coords = TRUE`.
+if ("old.coords" %in% names(formals(stats::density.default))) {
+  registerS3method(
+    "density", "default",
+    function(..., old.coords = TRUE) {
+      stats::density.default(..., old.coords = old.coords)
+    }
+  )
+}