do not preserve orderedness (#6486)

teunbrand · web-flow · commit cd852f7cf4b1 · 2025-10-20T14:38:04.000+02:00
diff --git a/R/reshape-add-margins.R b/R/reshape-add-margins.R
@@ -8,7 +8,7 @@ reshape_add_margins <- function(df, vars, margins = TRUE) {
   # Prepare data frame for addition of margins
   addAll <- function(x) {
     x <- addNA(x, TRUE)
-    factor(x, levels = c(levels(x), "(all)"), exclude = NULL)
+    factor(x, levels = c(levels(x), "(all)"), exclude = NULL, ordered = FALSE)
   }
   vars <- unique0(unlist(margin_vars))
   df[vars] <- lapply(df[vars], addAll)

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ reshape_add_margins <- function(df, vars, margins = TRUE) {`
`8`	`8`	`# Prepare data frame for addition of margins`
`9`	`9`	`addAll <- function(x) {`
`10`	`10`	`x <- addNA(x, TRUE)`
`11`		`- factor(x, levels = c(levels(x), "(all)"), exclude = NULL)`
	`11`	`+ factor(x, levels = c(levels(x), "(all)"), exclude = NULL, ordered = FALSE)`
`12`	`12`	`}`
`13`	`13`	`vars <- unique0(unlist(margin_vars))`
`14`	`14`	`df[vars] <- lapply(df[vars], addAll)`