pillar is now in Suggests, closes #9

krlmlr · krlmlr · commit 386685642ef7 · 2018-03-24T00:34:57.000+01:00
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -10,17 +10,17 @@ Description: R's raw vector is useful for storing a single binary object.
     What if you want to put a vector of them in a data frame? The 'blob'
     package provides the blob object, a list of raw vectors, suitable for
     use as a column in data frame.
-Imports:
+License: GPL-3
+URL: https://github.com/tidyverse/blob
+BugReports: https://github.com/tidyverse/blob/issues
+Imports: 
     methods,
-    pillar,
     prettyunits
-License: GPL-3
+Suggests: 
+    covr,
+    pillar (>= 1.2.1),
+    testthat
 Encoding: UTF-8
 LazyData: true
-URL: https://github.com/hadley/blob
-BugReports: https://github.com/hadley/blob/issues
-Suggests:
-    testthat,
-    covr
 Roxygen: list(markdown = TRUE, roclets = c("collate", "namespace", "rd", "pkgapi::api_roclet"))
 RoxygenNote: 6.0.1
diff --git a/R/format.R b/R/format.R
@@ -36,8 +36,7 @@ blob_size <- function(x, digits = 3, trim = TRUE, ...) {
   prettyunits::pretty_bytes(x)
 }
 
-#' @importFrom pillar pillar_shaft
-#' @export
+# Dynamically exported, see zzz.R
 pillar_shaft.blob <- function(x, ...) {
   out <- ifelse(
     is.na(x),
diff --git a/R/zzz.R b/R/zzz.R
@@ -0,0 +1,31 @@
+# nocov start
+.onLoad <- function(...) {
+  register_s3_method("pillar", "pillar_shaft", "blob")
+
+  invisible()
+}
+
+register_s3_method <- function(pkg, generic, class, fun = NULL) {
+  stopifnot(is.character(pkg), length(pkg) == 1)
+  stopifnot(is.character(generic), length(generic) == 1)
+  stopifnot(is.character(class), length(class) == 1)
+
+  if (is.null(fun)) {
+    fun <- get(paste0(generic, ".", class), envir = parent.frame())
+  } else {
+    stopifnot(is.function(fun))
+  }
+
+  if (pkg %in% loadedNamespaces()) {
+    registerS3method(generic, class, fun, envir = asNamespace(pkg))
+  }
+
+  # Always register hook in case package is later unloaded & reloaded
+  setHook(
+    packageEvent(pkg, "onLoad"),
+    function(...) {
+      registerS3method(generic, class, fun, envir = asNamespace(pkg))
+    }
+  )
+}
+# nocov end

Original file line number	Diff line number	Diff line change
`@@ -36,8 +36,7 @@ blob_size <- function(x, digits = 3, trim = TRUE, ...) {`
`36`	`36`	`prettyunits::pretty_bytes(x)`
`37`	`37`	`}`
`38`	`38`
`39`		`-#' @importFrom pillar pillar_shaft`
`40`		`-#' @export`
	`39`	`+# Dynamically exported, see zzz.R`
`41`	`40`	`pillar_shaft.blob <- function(x, ...) {`
`42`	`41`	`out <- ifelse(`
`43`	`42`	`is.na(x),`