Skip to content

Commit f918a7b

Browse files
authored
Merge pull request #244 from tidymodels/fit-sig
better fit* S3 signature
2 parents 7c9984d + 829de73 commit f918a7b

File tree

6 files changed

+19
-19
lines changed

6 files changed

+19
-19
lines changed

R/fit.R

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,8 @@
8989
#' @export fit.model_spec
9090
fit.model_spec <-
9191
function(object,
92-
formula = NULL,
93-
data = NULL,
92+
formula,
93+
data,
9494
control = control_parsnip(),
9595
...
9696
) {
@@ -180,8 +180,8 @@ fit.model_spec <-
180180
#' @export fit_xy.model_spec
181181
fit_xy.model_spec <-
182182
function(object,
183-
x = NULL,
184-
y = NULL,
183+
x,
184+
y,
185185
control = control_parsnip(),
186186
...
187187
) {

docs/dev/articles/articles/Classification.html

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/dev/articles/articles/Regression.html

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/dev/articles/articles/Scratch.html

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/dev/reference/fit.html

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/fit.Rd

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)