Updating for nearest_neighbor() engine specific args

Author: juliasilge

R/nearest_neighbor.R

@@ -96,7 +96,8 @@ update.nearest_neighbor <- function(object,
                                     weight_func = NULL,
                                     dist_power = NULL,
                                     fresh = FALSE, ...) {
-  update_dot_check(...)
+
+  eng_args <- update_engine_parameters(object$eng_args, ...)
 
   if (!is.null(parameters)) {
     parameters <- check_final_param(parameters)
@@ -112,12 +113,15 @@ update.nearest_neighbor <- function(object,
 
   if (fresh) {
     object$args <- args
+    object$eng_args <- eng_args
   } else {
     null_args <- map_lgl(args, null_value)
     if (any(null_args))
       args <- args[!null_args]
     if (length(args) > 0)
       object$args[names(args)] <- args
+    if (length(eng_args) > 0)
+      object$eng_args[names(eng_args)] <- eng_args
   }
 
   new_model_spec(

tests/testthat/test_nearest_neighbor.R

@@ -81,18 +81,18 @@ test_that('engine arguments', {
 
 test_that('updating', {
 
-  expr1     <- nearest_neighbor()  %>% set_engine("kknn", scale = FALSE)
+  expr1     <- nearest_neighbor()  %>% set_engine("kknn", scale = varying())
   expr1_exp <- nearest_neighbor(neighbors = 5) %>% set_engine("kknn", scale = FALSE)
 
   expr2     <- nearest_neighbor(neighbors = varying()) %>% set_engine("kknn")
   expr2_exp <- nearest_neighbor(neighbors = varying(), weight_func = "triangular") %>% set_engine("kknn")
 
-  expr3     <- nearest_neighbor(neighbors = 2, weight_func = varying()) %>% set_engine("kknn")
-  expr3_exp <- nearest_neighbor(neighbors = 3) %>% set_engine("kknn")
+  expr3     <- nearest_neighbor(neighbors = 2, weight_func = varying()) %>% set_engine("kknn", scale = varying())
+  expr3_exp <- nearest_neighbor(neighbors = 3) %>% set_engine("kknn", scale = FALSE)
 
-  expect_equal(update(expr1, neighbors = 5), expr1_exp)
+  expect_equal(update(expr1, neighbors = 5, scale = FALSE), expr1_exp)
   expect_equal(update(expr2, weight_func = "triangular"), expr2_exp)
-  expect_equal(update(expr3, neighbors = 3, fresh = TRUE), expr3_exp)
+  expect_equal(update(expr3, neighbors = 3, fresh = TRUE, scale = FALSE), expr3_exp)
 
   param_tibb <- tibble::tibble(neighbors = 7, dist_power = 1)
   param_list <- as.list(param_tibb)